Improve handling of Assert.Inconclusive #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AbhitejJohn
approved these changes
Sep 28, 2017
| @@ -231,7 +231,7 @@ private TestResult ExecuteInternal(object[] arguments) | |||
|
|
|||
| if (result.Outcome != TestTools.UnitTesting.UnitTestOutcome.Passed) | |||
| { | |||
| if (ex.InnerException != null && ex.InnerException is AssertInconclusiveException) | |||
| if (ex is UTF.AssertInconclusiveException || ex.InnerException is UTF.AssertInconclusiveException) | |||
There was a problem hiding this comment.
can we please add a null check for ex.InnerException?
There was a problem hiding this comment.
That should not be needed, as is will return false when compared to null. If for clarity or performance reasons, I can add it back in. The expression became harder to read and the effect is the same.
There was a problem hiding this comment.
That's fair. Don't think there would be much of a perf hit.
|
Thanks for helping out. |
jayaranigarg
approved these changes
Sep 28, 2017
| public void TestMethodInfoInvokeShouldHandleThrowAssertInconclusive() | ||
| { | ||
| DummyTestClass.TestMethodBody = (d) => { throw new UTF.AssertInconclusiveException(); }; | ||
| var asyncMethodInfo = typeof(DummyTestClass).GetMethod("DummyAsyncTestMethod"); |
There was a problem hiding this comment.
- We would want to do GetMethod on "DummyTestMethod" here..
- Should we just name the variable as "methodInfo" rather than "asyncMethodInfo" ?
There was a problem hiding this comment.
Yes and almost. methodInfo was a class member, so I've made it "dummyMethodInfo" instead.
|
Jesse, great to see this; thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help solve issues found in #249
This change is