Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No dockerfile for torchgeo #367

Closed
MATRIX4284 opened this issue Jan 25, 2022 · 4 comments
Closed

No dockerfile for torchgeo #367

MATRIX4284 opened this issue Jan 25, 2022 · 4 comments

Comments

@MATRIX4284
Copy link
Contributor

there is no docker images for torchgeo

@adamjstewart
Copy link
Collaborator

What would be the benefit of having a Docker image for TorchGeo? Most software, especially Python libraries, isn't distributed via Docker. We already have source code and wheels available on PyPI, and support package managers like pip/conda/spack. TorchGeo itself is pure-Python, so as long as you have one of the aforementioned package managers installed, you can easily install TorchGeo.

If we did provide Docker images, we would need to provide them for many OSes, CUDA versions, and Python versions. I don't see a benefit of this over package managers. But I don't use Docker heavily other than for reproducing bugs, so please correct me if I'm wrong.

@MATRIX4284
Copy link
Contributor Author

MATRIX4284 commented Feb 1, 2022

i added this because I tried to install torchgeo in my OS 4 times but was unable to import datasets while trying to run with Jupyter.Later on i came to know that is happening as i need to set my PROJ_LIB to the correct one before i run the jupyter.
To ease the usability while using open source jupyter to download datasets and visualize torcheo outputs the idea of torchgeo docker was provided.
It will enable the users to quickly get the environment with torchgeo up and running to use with jupyter notebook without needing to go for much OS isssues by trying to install on bare OS .This is enable more people in geospatial community to adapt torchgeo.
Moreover going forward geospatial will be used on cloud where containerization will play an important and anyhow people need to dockerize first to use torchgeo within micro-services framework.Again in that case this docker wil come as a useful feature.

@adamjstewart
Copy link
Collaborator

Later on i came to know that is happening as i need to set my PROJ_LIB to the correct one before i run the jupyter.

Yes, I've actually encountered this same issue myself. Package managers like Spack and Conda explicitly set this for you. If you're having problems with pip, I would suggest using a more powerful package manager like Spack or Conda. Pip isn't designed to install non-Python dependencies.

From what I can tell, the issue you reported is specific to PROJ and has nothing to do with TorchGeo. Maybe it would make more sense to add a Dockerfile to the PROJ library?

@adamjstewart
Copy link
Collaborator

Closing as it doesn't sound like this is a feature we really need in TorchGeo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants