Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyncTime public? #82

Closed
nsulikowski opened this issue May 6, 2019 · 1 comment
Closed

SyncTime public? #82

nsulikowski opened this issue May 6, 2019 · 1 comment

Comments

@nsulikowski
Copy link
Contributor

nsulikowski commented May 6, 2019

I’d submit that SyncTime and OtherTime should not be internal but public in the StreamEvent struct.
They are both integral concepts of the library.

@peterfreiling-zz
Copy link

These concepts are readily available via StreamEvent.StartTime/EndTime or PartitionedStreamEvent.StartTime/EndTime properties, which abstract a potential confusion for end-edge events, where SyncTime is the end time and OtherTime is the original start time corresponding to the end-edge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants