Skip to content
This repository has been archived by the owner on Jun 11, 2020. It is now read-only.

Definition files in sub folders are not detected #45

Closed
rhmoller opened this issue Jul 6, 2016 · 5 comments
Closed

Definition files in sub folders are not detected #45

rhmoller opened this issue Jul 6, 2016 · 5 comments

Comments

@rhmoller
Copy link

rhmoller commented Jul 6, 2016

When the definition-parser scans for .d.ts files, it should also look in sub-folders.

https://github.com/Microsoft/types-publisher/blob/master/src/lib/definition-parser.ts#L74

This affects react-router and other modules. See microsoft/TypeScript#9488

@mhegazy
Copy link
Contributor

mhegazy commented Jul 6, 2016

this is tracked by #3

@mhegazy
Copy link
Contributor

mhegazy commented Jul 6, 2016

I should add that PRs are always welcomed

@rhmoller
Copy link
Author

rhmoller commented Jul 6, 2016

It is not entirely the same. #3 is about a structure for maintaining typings for multiple versions of a library.

This issue is about supporting definitions that are split into multiple files with some of the files in a sub-folder

@mhegazy
Copy link
Contributor

mhegazy commented Jul 6, 2016

ah i see.

@mhegazy mhegazy reopened this Jul 6, 2016
@mhegazy mhegazy removed the duplicate label Jul 6, 2016
@ghost
Copy link

ghost commented Jul 12, 2016

Closed by #53

@ghost ghost closed this as completed Jul 12, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants