Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snappy] Support for non-BMI2 build #15794

Closed
ludekvodicka opened this issue Jan 21, 2021 · 6 comments
Closed

[snappy] Support for non-BMI2 build #15794

ludekvodicka opened this issue Jan 21, 2021 · 6 comments
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support depends:upstream-changes Waiting on a change to the upstream project

Comments

@ludekvodicka
Copy link
Contributor

We migrated the snappy library from our build to vcpkg. Unfortunately on some of our Windows virtual machines running on ESXI we're getting illegal instruction crash:

chrome_2021-01-21_14-42-39

Based on this post (https://stackoverflow.com/questions/61053436/how-to-build-snappy-on-windows-10-in-vs2015) it's necessary to disable SNAPPY_HAVE_BMI2 option.

Would be great to have a port option to build SNAPPY without BMI2 support

@ludekvodicka
Copy link
Contributor Author

This seems to be an issue in the Snappy: conda-forge/snappy-feedstock#24

This piece of code wrongly detects BMI2 also on non-supported platforms:

check_cxx_source_compiles("
#include <immintrin.h>
int main() {
  return _bzhi_u32(0, 1);
}" SNAPPY_HAVE_BMI2) 

@JackBoosY JackBoosY self-assigned this Jan 22, 2021
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Jan 22, 2021
@JackBoosY
Copy link
Contributor

Hmm... that seems like a upstream bug, can you report this to the upstream?

Thanks.

@JackBoosY JackBoosY added the depends:upstream-changes Waiting on a change to the upstream project label Jan 22, 2021
@ludekvodicka
Copy link
Contributor Author

ludekvodicka commented Jan 22, 2021

By upstream bug, you mean a bug directly in the snappy library?

I tried to report it but there is no "issue" section in the snappy repo and I didn't find any other way how to let them know.

https://github.com/google/snappy

@JackBoosY
Copy link
Contributor

@ludekvodicka Here https://groups.google.com/forum/#!forum/snappy-compression.

@FrankXie05
Copy link
Contributor

@ludekvodicka Is still work for this issue? Does the problem still exist?

@JackBoosY
Copy link
Contributor

Close this PR until upstream fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support depends:upstream-changes Waiting on a change to the upstream project
Projects
None yet
Development

No branches or pull requests

3 participants