Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magnum:x64-windows build failure #19261

Closed
e9x opened this issue Jul 31, 2021 · 5 comments
Closed

magnum:x64-windows build failure #19261

e9x opened this issue Jul 31, 2021 · 5 comments
Assignees
Labels
category:question This issue is a question

Comments

@e9x
Copy link

e9x commented Jul 31, 2021

Host Environment

  • OS: Windows 11
  • Compiler: Not relevant; Nothing can be compiled

To Reproduce
Steps to reproduce the behavior:
./vcpkg install --head corrade:x64-windows magnum:x64-windows

Failure logs

-- Downloading https://api.github.com/repos/mosra/magnum/git/refs/heads/master -> mosra-magnum-master.tar.gz.version...
-- Skipping hash check for D:/dev/vcpkg/downloads/temp/mosra-magnum-master.tar.gz.version.
-- Downloading https://github.com/mosra/magnum/archive/master.tar.gz -> mosra-magnum-master.tar.gz...
-- Skipping hash check for D:/dev/vcpkg/downloads/temp/mosra-magnum-master.tar.gz.
-- Extracting source D:/dev/vcpkg/downloads/mosra-magnum-master.tar.gz
-- Applying patch 001-tools-path.patch
CMake Error at scripts/cmake/z_vcpkg_apply_patches.cmake:61 (message):
  Applying patch failed: Checking patch modules/FindCorrade.cmake...

  error: while searching for:

          if(_component MATCHES ${_CORRADE_EXECUTABLE_COMPONENTS})
              add_executable(Corrade::${_component} IMPORTED)



              find_program(CORRADE_${_COMPONENT}_EXECUTABLE corrade-${_component})
              mark_as_advanced(CORRADE_${_COMPONENT}_EXECUTABLE)



              if(CORRADE_${_COMPONENT}_EXECUTABLE)



  error: patch failed: modules/FindCorrade.cmake:397

  error: modules/FindCorrade.cmake: patch does not apply

  Checking patch modules/FindMagnum.cmake...

  error: while searching for:

          if(_component MATCHES ${_MAGNUM_EXECUTABLE_COMPONENTS})
              add_executable(Magnum::${_component} IMPORTED)



              find_program(MAGNUM_${_COMPONENT}_EXECUTABLE magnum-${_component})
              mark_as_advanced(MAGNUM_${_COMPONENT}_EXECUTABLE)



              if(MAGNUM_${_COMPONENT}_EXECUTABLE)



  error: patch failed: modules/FindMagnum.cmake:493

  error: modules/FindMagnum.cmake: patch does not apply

Call Stack (most recent call first):
  scripts/cmake/vcpkg_extract_source_archive.cmake:230 (z_vcpkg_apply_patches)
  scripts/cmake/vcpkg_extract_source_archive_ex.cmake:32 (vcpkg_extract_source_archive)
  scripts/cmake/vcpkg_from_github.cmake:179 (vcpkg_extract_source_archive_ex)
  ports/magnum/portfile.cmake:1 (vcpkg_from_github)
  scripts/ports.cmake:140 (include)


Error: Building package magnum:x64-windows failed with: BUILD_FAILED

Additional context
As far as I can tell, git can't apply the patch 001-tools-path which is necessary for the port.
I am able to install magnum:x64-windows without the --head flag but it is a very old version that doesn't contain headers such as Magnum/Shaders/VertexColorGL.h.

@autoantwort
Copy link
Contributor

So the port builds normally, but you are requesting a port update :)

@autoantwort
Copy link
Contributor

autoantwort commented Jul 31, 2021

Ah it is already uses the latest release, but the latest release is one year old. mosra/magnum#453 is about the new release

@e9x
Copy link
Author

e9x commented Jul 31, 2021

I am not requesting a port update because this is a bug. Building from the head branch should have worked.

@NancyLi1013 NancyLi1013 added the category:question This issue is a question label Aug 2, 2021
@NancyLi1013
Copy link
Contributor

Hi @e9x

Thanks for posting this issue.

Since this is caused by using --head instead of the stable version in vcpkg. We cannot make sure if this can work fine on unstable git commit.

If you have the request to the new changes on master, you can use overlay-ports to update the patch on your local.

@NancyLi1013
Copy link
Contributor

Closing this issue for now, please feel free to reopen this issue if you have any problems when using overlay-ports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:question This issue is a question
Projects
None yet
Development

No branches or pull requests

3 participants