Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Exiv2] requires libiconv on windows which is not necessary. #27349

Closed
cos-public opened this issue Oct 20, 2022 · 0 comments · Fixed by #27370
Closed

[Exiv2] requires libiconv on windows which is not necessary. #27349

cos-public opened this issue Oct 20, 2022 · 0 comments · Fixed by #27370
Assignees
@Cheney-W
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@cos-public
Copy link

Environment

  • OS: Windows 10 64-bit
  • Compiler: MSVC 2019 community edition, current update

Is your feature request related to a problem? Please describe.
Exiv2 lists libiconv as a dependency. However it's explicitly stated in the Exiv2 docs, what it's not used on windows platform (https://github.com/Exiv2/exiv2/blob/main/README.md#Dependencies).

The library libiconv is a GNU library and we do not recommend using libiconv with Exiv2 when building with Visual Studio.

Proposed solution
Remove libiconv dependency for windows platform. (add "!windows" platform condition in vcpkg.json, fix vcpkg-cmake-wrapper.cmake)

Describe alternatives you've considered
Currently build script downloads msys and other stuff to build libiconv on windows which shouldn't be used.
@cos-public cos-public changed the title Exiv2 requires libiconv on windows which is not necessary. [Exiv2] requires libiconv on windows which is not necessary. Oct 20, 2022
@Cheney-W Cheney-W added the category:port-bug The issue is with a library, which is something the port should already support label Oct 21, 2022
@Cheney-W Cheney-W mentioned this issue Oct 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cheney-W Cheney-W

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[exiv2] Adding platform restrictions to Dependencies libiconv Cheney-W/vcpkg
2 participants
@cos-public @Cheney-W