Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg-gn] Build failure #29057

Closed
reitowo opened this issue Jan 19, 2023 · 6 comments · Fixed by #29058
Closed

[vcpkg-gn] Build failure #29057

reitowo opened this issue Jan 19, 2023 · 6 comments · Fixed by #29058
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@reitowo
Copy link
Contributor

reitowo commented Jan 19, 2023

I am fixing gn build on Windows, and while I'm trying to modify vcpkg-gn, I found vcpkg-gn is broken.
It seems the z_vcpkg_gn_real_path.cmake is not installed at all.

By the way, is this port deprecated? Show we prefer use built-in vcpkg_configure_gn instead?

Package: crashpad[core]:x64-windows -> 2022-09-05#1

Host Environment

  • Host: x64-windows
  • Compiler: MSVC 19.34.31937.0
  • vcpkg-tool version: 2022-12-14-7ae0d8527fb488fde10a89c2813802dc9b03b6f9
    vcpkg-scripts version: 5908d70 2023-01-17 (26 hours ago)

To Reproduce

vcpkg install crashpad

Failure logs

CMake Error at installed/x64-windows/share/vcpkg-gn/vcpkg_gn_configure.cmake:2 (include):
  include could not find requested file:

    C:/vcpkg/installed/x64-windows/share/vcpkg-gn/z_vcpkg_gn_real_path.cmake
Call Stack (most recent call first):
  installed/x64-windows/share/vcpkg-gn/vcpkg-port-config.cmake:1 (include)
  scripts/ports.cmake:134 (include)



E:\b\crashpad\build-x64-windows-dbg-out.log
ninja: Entering directory `E:/b/crashpad/x64-windows-dbg'
E:\b\crashpad\build-x64-windows-dbg-err.log
ninja: error: FindFirstFileExA(../../../../c:/vcpkg/installed/x64-windows/debug/lib): �ļ�����Ŀ¼�������������ȷ��


Additional context

@reitowo reitowo added the category:port-bug The issue is with a library, which is something the port should already support label Jan 19, 2023
@dg0yt
Copy link
Contributor

dg0yt commented Jan 19, 2023

By the way, is this port deprecated? Show we prefer use built-in vcpkg_configure_gn instead?

I suppose it was meant to be the future. But I found that it it is not used in vcpkg, and it did not really make any progress. This is were I would move changes as I did to the skia port when I have enough confidence that I can generalize them.

@dg0yt
Copy link
Contributor

dg0yt commented Jan 19, 2023

BTW IMO building the gn tool from source is still an option if there are good reasons. vcpkg also build qmake and pkgconf.

@reitowo
Copy link
Contributor Author

reitowo commented Jan 19, 2023

BTW IMO building the gn tool from source is still an option if there are good reasons. vcpkg also build qmake and pkgconf.

There're good reasons (like #29058) that we can apply patches, but #28974 said no.

@Cheney-W Cheney-W self-assigned this Jan 19, 2023
@dg0yt
Copy link
Contributor

dg0yt commented Jan 19, 2023

but #28974 said no.

... I know that answer. But this is the first-level review, sometimes not deep enough. Second-level review may have a different opinion, at least if it breaks manifest mode users in Visual Studio.

@reitowo
Copy link
Contributor Author

reitowo commented Jan 19, 2023

... I know that answer. But this is the first-level review, sometimes not deep enough. Second-level review may have a different opinion, at least if it breaks manifest mode users in Visual Studio.

Agree, and let's first try the cmake patch, both way works.

@reitowo
Copy link
Contributor Author

reitowo commented Feb 2, 2024

To follow up, I'm trying to patch this in gn upstream https://gn-review.googlesource.com/c/gn/+/16620.
I also confirmed this patch fixed the path issue. https://bugs.chromium.org/p/gn/issues/detail?id=317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants