-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg-gn] Build failure #29057
Comments
I suppose it was meant to be the future. But I found that it it is not used in vcpkg, and it did not really make any progress. This is were I would move changes as I did to the skia port when I have enough confidence that I can generalize them. |
BTW IMO building the gn tool from source is still an option if there are good reasons. vcpkg also build |
... I know that answer. But this is the first-level review, sometimes not deep enough. Second-level review may have a different opinion, at least if it breaks manifest mode users in Visual Studio. |
Agree, and let's first try the cmake patch, both way works. |
To follow up, I'm trying to patch this in gn upstream https://gn-review.googlesource.com/c/gn/+/16620. |
I am fixing gn build on Windows, and while I'm trying to modify
vcpkg-gn
, I foundvcpkg-gn
is broken.It seems the
z_vcpkg_gn_real_path.cmake
is not installed at all.By the way, is this port deprecated? Show we prefer use built-in
vcpkg_configure_gn
instead?Package: crashpad[core]:x64-windows -> 2022-09-05#1
Host Environment
vcpkg-scripts version: 5908d70 2023-01-17 (26 hours ago)
To Reproduce
vcpkg install crashpad
Failure logs
E:\b\crashpad\build-x64-windows-dbg-out.log
E:\b\crashpad\build-x64-windows-dbg-err.log
Additional context
The text was updated successfully, but these errors were encountered: