-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pcl] Build error on modified x64-windows-static #37624
Comments
community triplet. |
But identical to |
I most likely found the problem: there is an |
@mvieth Don't worry, I'll fix it. :) |
I do worry. Please prepare a fix upstream. Than I can pick it easily into the collection of port |
I probably created my triplet before |
I opened a draft PR: PointCloudLibrary/pcl#5985. |
@dg0yt I would like to add some more changes to this patch file: https://github.com/microsoft/vcpkg/blob/master/ports/pcl/fix-pcl-exports.patch , so that it is equivalent to this commit on the PCL master branch: PointCloudLibrary/pcl@e9d7131 Related: PointCloudLibrary/pcl#5984 |
Hm, is it to fix a bug? The total level of patching is already questionable. (And so are some patches.) A pcl patch release could be a more better starting point. |
Yes, it fixes a bug ( PointCloudLibrary/pcl#5984 ). The next PCL release 1.14.1 is indeed not in the too far future, but I thought it would be nice to have this fixed on vcpkg already before that. |
But the port is more and more decoupling from the official release. And every user carries the git repo with the patch history for all ports... |
In the end, it is not my decision, and I am okay with it if the patch is not added/extended. Just out of curiosity: is there a vcpkg guideline defining which changes are patch-worthy? New features would obviously not be accepted as patches, but are there specific criteria a bug-fixing patch must meet? |
(I picked the change already in parallel.) |
Should be fixed now with #37785 merged. |
With fbc542f, the build succeeds:
|
Package: pcl[apps,core,opengl,openni2,qt,visualization,vtk]:x64-windows-my@1.14.0#2
Host Environment
vcpkg-scripts version: 9765877 2024-03-20 (2 days ago)
C:\Libs\vcpkg\triplets\x64-windows-my.cmake
:To Reproduce
vcpkg install pcl[vtk,apps,visualization]
Failure logs
C:\Libs\vcpkg\buildtrees\pcl\install-x64-windows-my-rel-out.log
The text was updated successfully, but these errors were encountered: