[vcpkg] Use Windows SDK path directly instead of the hard-coded path #11421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Adriankhl
changed the title
|
Ok, I will close this PR if either one of those is merged. |
ghost
mentioned this pull request
JackBoosY
added
the
category:vcpkg-bug
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Jul 2, 2020
…ding Windows SDK paths. Also delete vcpkg_get_program_files_32_bit because it was used in only one place. Resolves microsoft#8288 Obsoletes microsoft#11421, microsoft#11261, microsoft#8329
ras0219-msft
pushed a commit
that referenced
this pull request
Jul 6, 2020
|
We believe this should be handled by #12232, thank you very much for your contribution and let us know if there are any remaining unaddressed issues! |
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
…ding Windows SDK paths. (microsoft#12232) Also delete vcpkg_get_program_files_32_bit because it was used in only one place. Resolves microsoft#8288 Obsoletes microsoft#11421, microsoft#11261, microsoft#8329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
My Windows SDK is installed in a non-default path, while wincrypt, winsock and opengl use a harded-coded Windows SDK path. This PR create a cmake function to make use of the
WindowsSdkDirvariable (if it exists) which is defined in the developer cmd.What does your PR fix? Fixes #
I guess it fixes this [opengl] build failure - Windows SDK path hardcoded #8288?
Does your PR follow the maintainer guide?
Not sure if I should separate it into several commits.