Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opengl wincrypt winsock2] Use $ENV{WindowsSdkDir} instead of hard coding Windows SDK paths. #12232

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

BillyONeal
Copy link
Member

Also delete vcpkg_get_program_files_32_bit because it was used in only one place.

Resolves #8288 (and probably others)
Obsoletes #11421, #11261, #8329

…ding Windows SDK paths.

Also delete vcpkg_get_program_files_32_bit because it was used in only one place.

Resolves microsoft#8288
Obsoletes microsoft#11421, microsoft#11261, microsoft#8329
@BillyONeal BillyONeal added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 2, 2020
@BillyONeal BillyONeal requested a review from JackBoosY July 2, 2020 23:03
Copy link
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vicroms vicroms added the info:reviewed Pull Request changes follow basic guidelines label Jul 2, 2020
@JackBoosY JackBoosY self-assigned this Jul 3, 2020
@JackBoosY
Copy link
Contributor

Related: #11261.

@ras0219-msft ras0219-msft merged commit 8eda81c into microsoft:master Jul 6, 2020
@BillyONeal BillyONeal deleted the windows_sdk branch September 22, 2020 00:04
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
…ding Windows SDK paths. (microsoft#12232)

Also delete vcpkg_get_program_files_32_bit because it was used in only one place.

Resolves microsoft#8288
Obsoletes microsoft#11421, microsoft#11261, microsoft#8329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[opengl] build failure - Windows SDK path hardcoded
4 participants