-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opengl] build failure - Windows SDK path hardcoded #8288
Comments
@AlessandroMenti, thanks for reporting this issue, could you summit a PR for this? |
Do you also know how to solve it in qmake's syntax/*.prl files (#7675) |
cmake
or 7.1 8.0 8.1 10.0
|
to locate system libraries)
? )) |
https://cmake.org/cmake/help/latest/variable/CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION.html
?
good example or
|
@PhoebeHui: of course! I've started working on a PR for this, see #8329 - I'll improve it in the next days. |
https://github.com/microsoft/vcpkg/blob/master/scripts/cmake/vcpkg_get_windows_sdk.cmake
$ENV{WindowsSDKVersion} open
version -
$ENV{WindowsSDKDir}
|
I think the best approach here would be to run a CMake build that simply performs something like
This should correctly find opengl from whichever windows sdk we're using to configure cmake projcets. |
Probably needs an opengl selector somehow since opengl32 from the windows sdk is not the only possibility if mesa is installed |
…ding Windows SDK paths. Also delete vcpkg_get_program_files_32_bit because it was used in only one place. Resolves microsoft#8288 Obsoletes microsoft#11421, microsoft#11261, microsoft#8329
…ding Windows SDK paths. (microsoft#12232) Also delete vcpkg_get_program_files_32_bit because it was used in only one place. Resolves microsoft#8288 Obsoletes microsoft#11421, microsoft#11261, microsoft#8329
Host Environment
To Reproduce
Steps to reproduce the behavior:
./vcpkg install opengl
Failure logs
Additional context
The portfiles for OpenGL hardcode the Windows 8 and 10 SDK paths:
This assumes that the Windows SDK is always installed in the default path, which might not always be the case (on my machine, it was installed into
D:\Program Files (x86)\Windows Kits\10
, hence the error).From a quick search, the issue seems to also affect the
wincrypt
andwinsock2
ports.A possible fix (at least for the Windows 10 SDK) would be to have CMake read the installation path from
HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows Kits\Installed Roots
(value name:KitsRoot10
) and to use it instead of the hardcoded one - I can draft a PR if needed.The text was updated successfully, but these errors were encountered: