-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dartsim] Add new port #13320
[dartsim] Add new port #13320
Conversation
7b1b13e
to
f2b12a6
Compare
Apparently this need a bit more work, marking it as WIP. |
f2b12a6
to
1b89dd7
Compare
4975afd
to
0ccfcb1
Compare
The second patch failed to apply, could you update it? Checking patch cmake/DARTMacros.cmake... error: patch failed: cmake/DARTMacros.cmake:135 |
Yes, I already fixed it locally, I need to push it upstream, but the port is still blocked by #12795 . |
0ccfcb1
to
7eb7b1b
Compare
7eb7b1b
to
9f6b225
Compare
The PR is now failing due to the error:
That is probably due to #8753 . However, an obvious workaround is to add an explicit dependency on |
The CI tests are now running correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes looks good to me, thanks for your contribution!
Thanks! |
@@ -0,0 +1,25 @@ | |||
{ | |||
"name": "dartsim", | |||
"version-string": "9.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this version be 6.9.4
to match the one in portfile.cmake
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick patch!
Describe the pull request
What does your PR fix? This PR adds a new port for the DART (Dynamic Animation and Robotics Toolkit) library, a articulated body simulated library used in Robotics and Graphics (http://dartsim.github.io/). Fix [New Port Request] Dynamic Animation and Robotics Toolkit (DART) #10015 .
Which triplets are supported/not supported? Have you updated the CI baseline?
As far as I know all the triplet should be supported.
Does your PR follow the maintainer guide?
Yes