Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dartsim] Add new port #13320

Merged
merged 4 commits into from
Sep 15, 2020
Merged

[dartsim] Add new port #13320

merged 4 commits into from
Sep 15, 2020

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Sep 2, 2020

Describe the pull request

@PhoebeHui PhoebeHui added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 3, 2020
@traversaro
Copy link
Contributor Author

Apparently this need a bit more work, marking it as WIP.

@traversaro traversaro changed the title [dartsim] Add new port [WIP] [dartsim] Add new port Sep 3, 2020
@PhoebeHui PhoebeHui marked this pull request as draft September 3, 2020 07:26
@traversaro traversaro changed the title [WIP] [dartsim] Add new port [dartsim] Add new port Sep 3, 2020
@traversaro traversaro marked this pull request as ready for review September 3, 2020 15:46
@traversaro traversaro force-pushed the add-dartsim branch 2 times, most recently from 4975afd to 0ccfcb1 Compare September 3, 2020 15:55
@PhoebeHui
Copy link
Contributor

The second patch failed to apply, could you update it?

Checking patch cmake/DARTMacros.cmake...
error: while searching for:
endif()
else()
set(HAVE_${variable} FALSE CACHE BOOL "Check if ${variable} found." FORCE)
if(ARGV3) # version
message(WARNING "Looking for ${dependency} - NOT found, to use"
" ${component}, please install ${dependency} (>= ${ARGV3})")
else()
message(WARNING "Looking for ${dependency} - NOT found, to use"
" ${component}, please install ${dependency}")
endif()
return()
endif()

error: patch failed: cmake/DARTMacros.cmake:135
error: cmake/DARTMacros.cmake: patch does not apply

@traversaro
Copy link
Contributor Author

Yes, I already fixed it locally, I need to push it upstream, but the port is still blocked by #12795 .

@traversaro
Copy link
Contributor Author

Yes, I already fixed it locally, I need to push it upstream, but the port is still blocked by #12795 .

#12795 has been merged, I just rebased the PR on the top of the latest master.

@traversaro
Copy link
Contributor Author

The PR is now failing due to the error:

FAILED: dart/utils/CMakeFiles/dart-utils.dir/XmlHelpers.cpp.o 
/usr/bin/c++  -DBOOST_TEST_DYN_LINK -I/mnt/vcpkg-ci/buildtrees/dartsim/src/v6.9.4-8a922c6dbc.clean -I. -isystem /mnt/vcpkg-ci/installed/x64-linux/share/eigen3/../../include/eigen3 -isystem /mnt/vcpkg-ci/installed/x64-linux/include -fPIC -Wall -Wextra -fPIC -g -fno-omit-frame-pointer -fno-inline-functions -fno-inline-functions-called-once -fno-optimize-sibling-calls -MD -MT dart/utils/CMakeFiles/dart-utils.dir/XmlHelpers.cpp.o -MF dart/utils/CMakeFiles/dart-utils.dir/XmlHelpers.cpp.o.d -o dart/utils/CMakeFiles/dart-utils.dir/XmlHelpers.cpp.o -c /mnt/vcpkg-ci/buildtrees/dartsim/src/v6.9.4-8a922c6dbc.clean/dart/utils/XmlHelpers.cpp
In file included from /mnt/vcpkg-ci/installed/x64-linux/include/boost/lexical_cast/detail/converter_lexical_streams.hpp:63:0,
                 from /mnt/vcpkg-ci/installed/x64-linux/include/boost/lexical_cast/detail/converter_lexical.hpp:54,
                 from /mnt/vcpkg-ci/installed/x64-linux/include/boost/lexical_cast/try_lexical_convert.hpp:44,
                 from /mnt/vcpkg-ci/installed/x64-linux/include/boost/lexical_cast.hpp:32,
                 from /mnt/vcpkg-ci/buildtrees/dartsim/src/v6.9.4-8a922c6dbc.clean/dart/utils/XmlHelpers.cpp:38:
/mnt/vcpkg-ci/installed/x64-linux/include/boost/lexical_cast/detail/inf_nan.hpp:34:10: fatal error: boost/math/special_functions/sign.hpp: No such file or directory
 #include <boost/math/special_functions/sign.hpp>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

That is probably due to #8753 . However, an obvious workaround is to add an explicit dependency on boost-math.

@traversaro
Copy link
Contributor Author

The CI tests are now running correctly.

@PhoebeHui PhoebeHui removed depends:different-pr This PR or Issue depends on a PR which has been filed requires:author-response labels Sep 14, 2020
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Sep 14, 2020
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good to me, thanks for your contribution!

@ras0219-msft
Copy link
Contributor

Thanks!

@ras0219-msft ras0219-msft merged commit f1bef4a into microsoft:master Sep 15, 2020
@@ -0,0 +1,25 @@
{
"name": "dartsim",
"version-string": "9.4.0",
Copy link
Contributor

@jslee02 jslee02 Sep 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this version be 6.9.4 to match the one in portfile.cmake?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @jslee02, I am not sure how the 9.4.0 ended there, probably when I migrated from the CONTROL file to the new vcpkg.json I copied an existing file and I forgot to update the version. A fix for this is in #13550 , let's hope the jump backword in version is not creating problems.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] Dynamic Animation and Robotics Toolkit (DART)
4 participants