Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ezc3d] Add new port #14016

Merged
merged 16 commits into from
Oct 20, 2020
Merged

[ezc3d] Add new port #14016

merged 16 commits into from
Oct 20, 2020

Conversation

RDCH106
Copy link
Contributor

@RDCH106 RDCH106 commented Oct 13, 2020

ezc3d - C3D reader/writer

  • What does your PR fix?

  • Which triplets are supported/not supported?

    • Expected supported triplets: Triplets tested by CI baseline
  • Have you updated the CI baseline?

    • Not updated the CI baseline.
  • Does your PR follow the maintainer guide?

@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 14, 2020
@RDCH106 RDCH106 marked this pull request as ready for review October 14, 2020 07:05
ports/ezc3d/CONTROL Outdated Show resolved Hide resolved
ports/ezc3d/portfile.cmake Outdated Show resolved Hide resolved
ports/ezc3d/portfile.cmake Outdated Show resolved Hide resolved
ports/ezc3d/portfile.cmake Outdated Show resolved Hide resolved
ports/ezc3d/portfile.cmake Outdated Show resolved Hide resolved
RDCH106 and others added 5 commits October 14, 2020 11:00
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@RDCH106
Copy link
Contributor Author

RDCH106 commented Oct 14, 2020

Neverending story version x64-osx 😅
@NancyLi1013 , maybe starting again the job...

ports/ezc3d/CONTROL Outdated Show resolved Hide resolved
ports/ezc3d/portfile.cmake Outdated Show resolved Hide resolved
@NancyLi1013
Copy link
Contributor

Neverending story version x64-osx 😅
@NancyLi1013 , maybe starting again the job...

@RDCH106
All work seems good now. So what do you mean about this comment?

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@RDCH106
Copy link
Contributor Author

RDCH106 commented Oct 15, 2020

Neverending story version x64-osx 😅
@NancyLi1013 , maybe starting again the job...

@RDCH106
All work seems good now. So what do you mean about this comment?

It was just a joke due to the x64_osx job duration. In the end, the job finalized.

imagen

@NancyLi1013
Copy link
Contributor

The format for vcpkg.json is not right. The end of line should be LF instead of CRLF.

@RDCH106
Copy link
Contributor Author

RDCH106 commented Oct 15, 2020

@NancyLi1013 done, but same error...

Currently, the command vcpkg create on Windows is generating vcpkg.json with CRLF line ending instead of LF.

@RDCH106
Copy link
Contributor Author

RDCH106 commented Oct 15, 2020

@NancyLi1013 , we can consider to revert conversion from CONTROL file to vcpkg.json manifest... Before it, the CI was passed successfully.

@RDCH106
Copy link
Contributor Author

RDCH106 commented Oct 16, 2020

Reverted conversion from CONTROL file to vcpkg.json manifest

I think it's ready 😁

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Oct 19, 2020
@BillyONeal BillyONeal merged commit 13af628 into microsoft:master Oct 20, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants