-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libspnav] Add new port #14052
[libspnav] Add new port #14052
Conversation
Thank you so much, PhoebeHui, Hoikas and NancyLi for helping! I applied your requested changes. |
If it's possible, can I try compiling and testing this on macOS tomorrow? (since it's 04:31 am here) I can then confirm if that works or not. |
Of course, you can do this at any time available for you. It's too late for you now. Please have a good rest first. You can update it tomorrow if it can support osx. |
I looked further into this and tried to compile it, and I'm sure it would make no sense to support macOS. This library was never intended to work for Mac since you need to use a user-space driver thats only available for Linux. On top of that, there's no X11 support for Mac anymore which is required (It's XQuartz now for quite some time). The commit was from 2013. I think Blender uses the proprietary driver on Windows and Mac and libspnav on Linux. I'm happy with the port! The only suggestion I could think of is maybe adding a comment explaining the confusion between ref |
Thanks for your further investigation about this new port. It's so great. |
Thanks for your contribution! |
What does your PR fix?
Adds
libspnav
from https://github.com/FreeSpacenav/libspnav which is for SpaceMouse support. Blender uses this same library for example.Which triplets are supported/not supported? Have you updated the CI baseline?
Just Linux. I was able to install through vcpkg with x64 and arm64. X11 was necessary to compile. Both
VCPKG_BUILD_TYPE
andVCPKG_LIBRARY_LINKAGE
are respected. I haven't touched the CI baseline.Does your PR follow the maintainer guide?
Yes, I think so.