Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[poco] Fix dependency and cmake config issue #14589

Merged
merged 2 commits into from Nov 18, 2020
Merged

[poco] Fix dependency and cmake config issue #14589

merged 2 commits into from Nov 18, 2020

Conversation

PhoebeHui
Copy link
Contributor

Fixes #14577

  1. Fix pcre and expat dependency issue.
  2. PocoConfig.cmake overwrites CMAKE_PREFIX_PATH, so expat is not found. It should append extra path to CMAKE_PREFIX_PATH.

Test:
find_package(Poco CONFIG REQUIRED Util)
target_link_libraries(pocotest PRIVATE Poco::Util)

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 16, 2020
linquize
linquize reviewed Nov 16, 2020
View reviewed changes
Copy link

@linquize linquize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 patch files to patch cmake/PocoConfig.cmake.in .

Is it better to put together into fix_dependency.patch ?

fix_cmake_config.patch also relates to dependency. Do you need a separate file?

@PhoebeHui
Copy link
Contributor Author

@linquize, thanks for your review!

I'm fine to merge them togather.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Nov 18, 2020
@strega-nil
Copy link
Contributor

Thanks Phoebe!

@strega-nil strega-nil merged commit 81daeaa into microsoft:master Nov 18, 2020
@PhoebeHui PhoebeHui deleted the dev/Phoebe/poco branch November 19, 2020 06:39
@traversaro traversaro mentioned this pull request Nov 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linquize linquize linquize left review comments

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[poco] 1.10.1 cmake integration error
4 participants
@PhoebeHui @strega-nil @linquize @JackBoosY