Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vcpkg and lukka/run-vcpkg versions #125

Merged
merged 3 commits into from
Nov 21, 2020

Conversation

jontje
Copy link
Contributor

@jontje jontje commented Nov 18, 2020

The Windows vcpkg CI started failing two days ago (see).

See ros-industrial/abb_libegm#113 (comment) for the cause.

This PR updates the vcpkg and lukka/run-vcpkg versions, similar to PR ros-industrial/abb_libegm#114, to fix this.

@gavanderhoorn
Copy link
Member

The changes look OK, but the vcpkg build still seems to be failing (here, in the CI for this PR I mean).

Do we know why?

@jontje
Copy link
Contributor Author

jontje commented Nov 20, 2020

Do we know why?

I took a brief look earlier and then it seemed like that poco failed to build, but I haven't had time to dig further.

@gavanderhoorn
Copy link
Member

I've restarted the build. Let's see what happens.

@traversaro
Copy link
Contributor

I see that there have been two recent PR related to poco:

For this reason, I guess we can either switch back to use the old vcpkg commit, or instead use the latest vcpkg commit, i.e. e803bf11296d8e7900dafb41e7b1224778d33dc6 as of this moment.

@gavanderhoorn
Copy link
Member

If the latest works, I'd say use that.

@jontje
Copy link
Contributor Author

jontje commented Nov 20, 2020

If the latest works, I'd say use that.

It worked 😄

Edit: For consistency I will update abb_libegm to also use the latest vcpkg.

@gavanderhoorn gavanderhoorn merged commit b41e3f1 into ros-industrial:master Nov 21, 2020
@gavanderhoorn
Copy link
Member

Thanks for fixing this @jontje and @traversaro 👍

@jontje jontje deleted the update_windows_vcpkg_ci branch November 23, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants