-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
directxtex, directxmesh, directxtk, uvatlas ports updated to fix cach… #15639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-collision issues
walbourn
commented
Jan 14, 2021
JackBoosY
added
the
category:port-bug
The issue is with a library, which is something the port should already support
label
Jan 14, 2021
JackBoosY
suggested changes
Jan 14, 2021
JackBoosY
approved these changes
Jan 15, 2021
JackBoosY
added
info:reviewed
Pull Request changes follow basic guidelines
and removed
requires:author-response
labels
Jan 15, 2021
Verified the ports build with all supported triplets:
Included Note that there isn't a |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-bug
The issue is with a library, which is something the port should already support
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves cache collision and subsequent hash problems for the cases where I download a presigned/prebuilt command-line tool instead of building it (x64-uwp for directxtex, directxmesh, directxtk; and uvatlas, x64-windows and x64-uwp for directxtk12). This fixes 'upgrade' scenarios that were a regression in the jan2021 port update.
Also rev'd these ports to jan2021b to include some minor upstream CMake cleanup to silence build warnings. This includes fixing some build breaks due to cmake default libs quirks with the
arm-windows
triplet for directxtex and uvatlas.