[vcpkg-cmake] Fix docs and usage of option MAYBE_UNUSED_VARIABLES #19245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
added
category:port-bug
|
cc @wrobelda, can you please check MAYBE_UNUSED_VARIABLES's values in your opened PRs? |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout fa1bbe097b26678e3fd992173b62279c071c422b -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/v-/vcpkg-cmake.json b/versions/v-/vcpkg-cmake.json
index 87ddd66..086edd0 100644
--- a/versions/v-/vcpkg-cmake.json
+++ b/versions/v-/vcpkg-cmake.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "8d70d64792b10b091a27d19372db25cfb74d9e9c",
+ "git-tree": "c6df7e0faeda9e783175746c7c440c9bc2bdb111",
"version-date": "2021-07-30",
"port-version": 0
},
JackBoosY
commented
Jul 30, 2021
added 2 commits
July 30, 2021 01:26
JackBoosY
added
the
requires:vcpkg-team-review
|
Need to check the related warning message after pipeline test. |
|
Question: should we also add the following requirement in https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md#build-techniques? |
This was referenced Jul 30, 2021
Merged
strega-nil-ms
approved these changes
Aug 3, 2021
PhoebeHui
approved these changes
Aug 3, 2021
PhoebeHui
added
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current document, our description of
MAYBE_UNUSED_VARIABLEScaused the user to misunderstand the parameter and incorporate the wrong changes.Fix the option description and add sample code to the docs.
Related: #13467