Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kf5solid] new port #19201

Merged
merged 14 commits into from
Aug 2, 2021
Merged

[kf5solid] new port #19201

merged 14 commits into from
Aug 2, 2021

Conversation

wrobelda
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    Adds new port

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    All official.

  • Does your PR follow the maintainer guide?

    Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes.

@wrobelda wrobelda marked this pull request as ready for review July 28, 2021 16:18
@JonLiu1993 JonLiu1993 self-assigned this Jul 29, 2021
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jul 29, 2021
ports/kf5solid/portfile.cmake Outdated Show resolved Hide resolved
ports/kf5solid/portfile.cmake Outdated Show resolved Hide resolved
ports/kf5solid/portfile.cmake Outdated Show resolved Hide resolved
ports/kf5solid/vcpkg.json Outdated Show resolved Hide resolved
ports/kf5solid/vcpkg.json Outdated Show resolved Hide resolved
Copy link
Contributor Author

@wrobelda wrobelda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JonLiu1993 Replaced outdated functions. All fixed now.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kf5solid but no changes to version or port version.
-- Version: 5.84.0
-- Old SHA: fe0d7f0aa2b4268ece72c61a8581ffefdfe02708
-- New SHA: 1ad5206b101075727f073bf37cef4541242ac625
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@JonLiu1993
Copy link
Member

Can you please resolve the conflicts against master?

@wrobelda
Copy link
Contributor Author

Can you please resolve the conflicts against master?

Done

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Aug 2, 2021
@dan-shaw dan-shaw merged commit 3d4ce76 into microsoft:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants