[slang] Adding a package for the Slang shading language #24914

djohansson · 2022-05-25T10:35:20Z

Adding a package for the Slang shading language (https://github.com/shader-slang/slang).
Uses the Github binary releases found at https://github.com/shader-slang/slang/releases

What does your PR fix?

(New package)

Which triplets are supported/not supported? Have you updated the [CI baseline]

x64-linux, x64-windows, x86-windows
CI baseline updated: Yes

Does your PR follow the maintainer guide?

Yes, I hope so.

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yup!

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/slang/vcpkg.json b/ports/slang/vcpkg.json
index d0896bf..b55f2bf 100644
--- a/ports/slang/vcpkg.json
+++ b/ports/slang/vcpkg.json
@@ -1,7 +1,6 @@
-{
-	"name": "slang",
-	"version": "0.23.13",
-	"homepage": "https://github.com/shader-slang/slang",
-	"description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
-	"dependencies": []
-}
\ No newline at end of file
+{
+  "name": "slang",
+  "version": "0.23.13",
+  "description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
+  "homepage": "https://github.com/shader-slang/slang"
+}

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 93b38546e271ac8047a6dd00469f14845beb4642 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 17debef..04c70b1 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6556,6 +6556,10 @@
       "baseline": "1.13.0",
       "port-version": 2
     },
+    "slang": {
+      "baseline": "0.23.13",
+      "port-version": 0
+    },
     "sleef": {
       "baseline": "3.5.1",
       "port-version": 2

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/slang/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/slang/vcpkg.json b/ports/slang/vcpkg.json
index d0896bf..b55f2bf 100644
--- a/ports/slang/vcpkg.json
+++ b/ports/slang/vcpkg.json
@@ -1,7 +1,6 @@
-{
-	"name": "slang",
-	"version": "0.23.13",
-	"homepage": "https://github.com/shader-slang/slang",
-	"description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
-	"dependencies": []
-}
\ No newline at end of file
+{
+  "name": "slang",
+  "version": "0.23.13",
+  "description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
+  "homepage": "https://github.com/shader-slang/slang"
+}

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout faed44dfa013088fe1910908a8a65887622f412f -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index a938c96..51f4c5a 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6568,6 +6568,10 @@
       "baseline": "1.13.0",
       "port-version": 2
     },
+    "slang": {
+      "baseline": "0.23.13",
+      "port-version": 0
+    },
     "sleef": {
       "baseline": "3.5.1",
       "port-version": 2

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/slang/vcpkg.json

Valid values for the license field can be found in the documentation

JonLiu1993 · 2022-06-24T08:45:20Z

@djohansson, Thanks for your pr , are you still work on this pr?

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/slang/vcpkg.json b/ports/slang/vcpkg.json
index d0896bf..b55f2bf 100644
--- a/ports/slang/vcpkg.json
+++ b/ports/slang/vcpkg.json
@@ -1,7 +1,6 @@
-{
-	"name": "slang",
-	"version": "0.23.13",
-	"homepage": "https://github.com/shader-slang/slang",
-	"description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
-	"dependencies": []
-}
\ No newline at end of file
+{
+  "name": "slang",
+  "version": "0.23.13",
+  "description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
+  "homepage": "https://github.com/shader-slang/slang"
+}

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 1323f4b83d6a91e415e9ce06a45c9d0a6473aaf2 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 8382ef3..5938cb6 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6612,6 +6612,10 @@
       "baseline": "1.13.0",
       "port-version": 2
     },
+    "slang": {
+      "baseline": "0.23.13",
+      "port-version": 0
+    },
     "sleef": {
       "baseline": "3.5.1",
       "port-version": 2

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/slang/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/slang/vcpkg.json b/ports/slang/vcpkg.json
index d0896bf..b55f2bf 100644
--- a/ports/slang/vcpkg.json
+++ b/ports/slang/vcpkg.json
@@ -1,7 +1,6 @@
-{
-	"name": "slang",
-	"version": "0.23.13",
-	"homepage": "https://github.com/shader-slang/slang",
-	"description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
-	"dependencies": []
-}
\ No newline at end of file
+{
+  "name": "slang",
+  "version": "0.23.13",
+  "description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
+  "homepage": "https://github.com/shader-slang/slang"
+}

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 4826ede84084395b0f87476e48ff6d4070eba0e4 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 8382ef3..5938cb6 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6612,6 +6612,10 @@
       "baseline": "1.13.0",
       "port-version": 2
     },
+    "slang": {
+      "baseline": "0.23.13",
+      "port-version": 0
+    },
     "sleef": {
       "baseline": "3.5.1",
       "port-version": 2

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/slang/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/slang/vcpkg.json b/ports/slang/vcpkg.json
index d0896bf..b55f2bf 100644
--- a/ports/slang/vcpkg.json
+++ b/ports/slang/vcpkg.json
@@ -1,7 +1,6 @@
-{
-	"name": "slang",
-	"version": "0.23.13",
-	"homepage": "https://github.com/shader-slang/slang",
-	"description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
-	"dependencies": []
-}
\ No newline at end of file
+{
+  "name": "slang",
+  "version": "0.23.13",
+  "description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
+  "homepage": "https://github.com/shader-slang/slang"
+}

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5f631cf95555320a10f87aec1a0444ae92a64454 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 818e9f4..1dbf2ae 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6624,6 +6624,10 @@
       "baseline": "1.13.0",
       "port-version": 2
     },
+    "slang": {
+      "baseline": "0.23.13",
+      "port-version": 0
+    },
     "sleef": {
       "baseline": "3.5.1",
       "port-version": 2

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/slang/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/slang/vcpkg.json b/ports/slang/vcpkg.json
index d0896bf..b55f2bf 100644
--- a/ports/slang/vcpkg.json
+++ b/ports/slang/vcpkg.json
@@ -1,7 +1,6 @@
-{
-	"name": "slang",
-	"version": "0.23.13",
-	"homepage": "https://github.com/shader-slang/slang",
-	"description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
-	"dependencies": []
-}
\ No newline at end of file
+{
+  "name": "slang",
+  "version": "0.23.13",
+  "description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
+  "homepage": "https://github.com/shader-slang/slang"
+}

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout f93ba152d55e1d243160e690bc302ffe8638358e -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 444d01f..6cbf321 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6640,6 +6640,10 @@
       "baseline": "1.13.0",
       "port-version": 2
     },
+    "slang": {
+      "baseline": "0.23.13",
+      "port-version": 0
+    },
     "sleef": {
       "baseline": "3.5.1",
       "port-version": 2

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/slang/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/slang/vcpkg.json b/ports/slang/vcpkg.json
index d0896bf..b55f2bf 100644
--- a/ports/slang/vcpkg.json
+++ b/ports/slang/vcpkg.json
@@ -1,7 +1,6 @@
-{
-	"name": "slang",
-	"version": "0.23.13",
-	"homepage": "https://github.com/shader-slang/slang",
-	"description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
-	"dependencies": []
-}
\ No newline at end of file
+{
+  "name": "slang",
+  "version": "0.23.13",
+  "description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
+  "homepage": "https://github.com/shader-slang/slang"
+}

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 66045de4dcc5da3d1029c02b606307f5951dcb22 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index d87cd72..f3d7853 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6644,6 +6644,10 @@
       "baseline": "1.13.0",
       "port-version": 2
     },
+    "slang": {
+      "baseline": "0.23.13",
+      "port-version": 0
+    },
     "sleef": {
       "baseline": "3.5.1",
       "port-version": 2

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/slang/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/slang/vcpkg.json b/ports/slang/vcpkg.json
index d0896bf..b55f2bf 100644
--- a/ports/slang/vcpkg.json
+++ b/ports/slang/vcpkg.json
@@ -1,7 +1,6 @@
-{
-	"name": "slang",
-	"version": "0.23.13",
-	"homepage": "https://github.com/shader-slang/slang",
-	"description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
-	"dependencies": []
-}
\ No newline at end of file
+{
+  "name": "slang",
+  "version": "0.23.13",
+  "description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
+  "homepage": "https://github.com/shader-slang/slang"
+}

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 48369f2a2aa00f7311ca8417cfd0fbda4bcc41e9 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 56e3fd4..18d3678 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6644,6 +6644,10 @@
       "baseline": "1.13.0",
       "port-version": 2
     },
+    "slang": {
+      "baseline": "0.23.13",
+      "port-version": 0
+    },
     "sleef": {
       "baseline": "3.5.1",
       "port-version": 2

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/slang/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/slang/vcpkg.json b/ports/slang/vcpkg.json
index d0896bfb..b55f2bfb 100644
--- a/ports/slang/vcpkg.json
+++ b/ports/slang/vcpkg.json
@@ -1,7 +1,6 @@
-{
-	"name": "slang",
-	"version": "0.23.13",
-	"homepage": "https://github.com/shader-slang/slang",
-	"description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
-	"dependencies": []
-}
\ No newline at end of file
+{
+  "name": "slang",
+  "version": "0.23.13",
+  "description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
+  "homepage": "https://github.com/shader-slang/slang"
+}

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout d293ac220dd126165d24907b6f07e6b658b3329f -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 6d7bffe8..728a462a 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6668,6 +6668,10 @@
       "baseline": "1.13.0",
       "port-version": 2
     },
+    "slang": {
+      "baseline": "0.23.13",
+      "port-version": 0
+    },
     "sleef": {
       "baseline": "3.5.1",
       "port-version": 2

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/slang/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/slang/vcpkg.json b/ports/slang/vcpkg.json
index d0896bfb..b55f2bfb 100644
--- a/ports/slang/vcpkg.json
+++ b/ports/slang/vcpkg.json
@@ -1,7 +1,6 @@
-{
-	"name": "slang",
-	"version": "0.23.13",
-	"homepage": "https://github.com/shader-slang/slang",
-	"description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
-	"dependencies": []
-}
\ No newline at end of file
+{
+  "name": "slang",
+  "version": "0.23.13",
+  "description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
+  "homepage": "https://github.com/shader-slang/slang"
+}

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5ace90c53049f39fccba94e9eb020780d165bae8 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 1d942429..0066f663 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6744,6 +6744,10 @@
       "baseline": "1.13.0",
       "port-version": 2
     },
+    "slang": {
+      "baseline": "0.23.13",
+      "port-version": 0
+    },
     "sleef": {
       "baseline": "3.5.1",
       "port-version": 2

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/slang/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/slang/vcpkg.json b/ports/slang/vcpkg.json
index d0896bfb..b55f2bfb 100644
--- a/ports/slang/vcpkg.json
+++ b/ports/slang/vcpkg.json
@@ -1,7 +1,6 @@
-{
-	"name": "slang",
-	"version": "0.23.13",
-	"homepage": "https://github.com/shader-slang/slang",
-	"description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
-	"dependencies": []
-}
\ No newline at end of file
+{
+  "name": "slang",
+  "version": "0.23.13",
+  "description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
+  "homepage": "https://github.com/shader-slang/slang"
+}

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout a291bcad8093f9f17988fe66543aefd674812f0e -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index b8b81f85..3d467860 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6760,6 +6760,10 @@
       "baseline": "1.13.0",
       "port-version": 2
     },
+    "slang": {
+      "baseline": "0.23.13",
+      "port-version": 0
+    },
     "sleef": {
       "baseline": "3.5.1",
       "port-version": 2

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/slang/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/slang/vcpkg.json b/ports/slang/vcpkg.json
index d0896bfb..b55f2bfb 100644
--- a/ports/slang/vcpkg.json
+++ b/ports/slang/vcpkg.json
@@ -1,7 +1,6 @@
-{
-	"name": "slang",
-	"version": "0.23.13",
-	"homepage": "https://github.com/shader-slang/slang",
-	"description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
-	"dependencies": []
-}
\ No newline at end of file
+{
+  "name": "slang",
+  "version": "0.23.13",
+  "description": "Slang is a shading language that makes it easier to build and maintain large shader codebases in a modular and extensible fashion, while also maintaining the highest possible performance on modern GPUs and graphics APIs. Slang is based on years of collaboration between researchers at NVIDIA, Carnegie Mellon University, and Stanford.",
+  "homepage": "https://github.com/shader-slang/slang"
+}

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5f82fa45df07a446bab57f65479f3d2df797f408 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 5b80040e..00c8a6b4 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6812,6 +6812,10 @@
       "baseline": "1.13.0",
       "port-version": 2
     },
+    "slang": {
+      "baseline": "0.23.13",
+      "port-version": 0
+    },
     "sleef": {
       "baseline": "3.5.1",
       "port-version": 2

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/slang/vcpkg.json

Valid values for the license field can be found in the documentation

JonLiu1993 · 2022-10-11T06:31:00Z

Pinging @djohansson for response. Is work still being done for this PR?

BillyONeal

Couple notes:

Normally duplicating release libs into the debug tree would be bad, because the CRT wouldn't match. However, this presumably passed our post build check that looks for that.
LLVM is vendored, but only in binary forms. I think there is likely a concern on Linux over this, but maybe not.
Several other libraries that are in vcpkg are vendored as well, as documented here: https://github.com/shader-slang/slang#license

The vendoring is a bit scary but probably OK given that this thing is being deployed in binary forms.

This "request changes" review is mainly about why VCPKG_POLICY_EMPTY_INCLUDE_FOLDER is being turned on.

BillyONeal · 2022-10-29T03:56:51Z

ports/shader-slang/portfile.cmake

@@ -0,0 +1,83 @@
+set(VCPKG_POLICY_EMPTY_INCLUDE_FOLDER enabled)


Line 72 installs headers, so why did you need this policy?

It was added by mistake, copy-pasting from other ports. I have removed it now.

BillyONeal · 2022-10-29T03:58:37Z

New port checklist:

Thanks for checking these out for me @JonLiu1993 :)

BillyONeal · 2022-10-29T04:00:15Z

Hmmm scratch all my comments about vendoring; it looks like those parts are used only in the tool binaries, which makes it conclusively fine. Just the question about empty include folder...

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for shader-slang have changed but the version was not updated
version: 0.23.13
old SHA: 314ad4a973d1069ef30b3bc74280ba99f00768f3
new SHA: d636f8643fe4aa1ace94e4abd3d156a8074ea59f
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

BillyONeal · 2022-10-31T20:48:23Z

Thanks!

@dg0yt

@BillyONeal

* When @BillyONeal started being the on-call vcpkg maintainer on 2022-10-17, he started applying use of the "embedded VERSION" feature microsoft/vcpkg-tool#717 to PRs on merge. @dg0yt points out that this use should be accompanied by a call to vcpkg_minimum_required, in https://github.com/microsoft/vcpkg/pull/27594/files#r1010641672 This is an audit of everything merged in that time and whether it needs to gain that. #27561 No VERSION #27525 No VERSION #27554 Already has vcpkg_minimum_required #27536 No VERSION #27562 No VERSION #24914 Fixed here #27547 No VERSION #27502 No VERSION #27497 No VERSION #27317 No VERSION #27288 No VERSION #27509 No VERSION #27504 No VERSION #27514 No VERSION #27501 No VERSION #27495 No VERSION #27488 No VERSION #27499 No VERSION #27378 No VERSION #27376 Fixed here #27373 No VERSION #27045 No VERSION #27521 No VERSION #27453 No VERSION #27481 No VERSION #27511 No VERSION #27490 No VERSION #27510 No VERSION #27496 No VERSION #27503 No VERSION #27485 No VERSION #27484 No VERSION #27483 No VERSION #27459 No VERSION #27369 No VERSION #27489 No VERSION #26594 No VERSION #27465 No VERSION #27456 No VERSION #27425 No VERSION #27464 Fixed here #27406 No VERSION #27398 No VERSION #27240 No VERSION #27450 No VERSION #27463 No VERSION #27462 No VERSION #27448 No VERSION #27440 No VERSION #27435 No VERSION #27424 No VERSION #27414 No VERSION #27412 No VERSION #27380 No VERSION #27343 No VERSION #27342 No VERSION #27367 No VERSION #27226 No VERSION #27320 No VERSION #26923 No VERSION #27284 No VERSION #27433 No VERSION #27314 VERSION got *removed* #27335 No VERSION #27370 No VERSION #27324 No VERSION #27391 No VERSION #27388 No VERSION #27396 No VERSION #27404 No VERSION #27413 No VERSION #27417 No VERSION #27427 No VERSION #27428 No VERSION #27368 No VERSION #27307 No VERSION #27415 Fixed here. #27371 Fixed here. #27323 No VERSION #27352 No VERSION #27347 No VERSION #27366 No VERSION #27361 No VERSION #27359 No VERSION #27358 No VERSION #27355 No VERSION #27331 No VERSION #24615 No VERSION #27325 No VERSION #24861 No VERSION #27354 No VERSION #27346 No VERSION #27345 No VERSION #27218 No VERSION #27329 No VERSION #27326 No VERSION #27321 No VERSION #27312 No VERSION #27297 No VERSION #27336 No VERSION #27225 No VERSION #27339 No VERSION #27302 No VERSION #27295 No VERSION #27233 No VERSION #27313 No VERSION #27237 No VERSION #27250 No VERSION #27263 No VERSION #27266 No VERSION #27272 No VERSION #27287 No VERSION #27282 No VERSION #27294 No VERSION #27228 No VERSION #27163 No VERSION #26817 No VERSION #27286 No VERSION #27274 No VERSION #27276 No VERSION #27232 No VERSION #27221 No VERSION #27215 No VERSION #27166 No VERSION #27239 No VERSION #27246 No VERSION #27268 No VERSION #27259 No VERSION #27238 No VERSION #27224 No VERSION #27203 No VERSION #27124 No VERSION * Also add libcanberra

djohansson added 2 commits May 23, 2022 13:52

slang port - initial commit

4fbc0de

added x64-linux target and removed dependency on cmake

da199bb

github-actions bot requested changes May 25, 2022

View reviewed changes

FrankXie05 assigned JonLiu1993 May 26, 2022

JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 26, 2022

PhoebeHui changed the title ~~Adding a package for the Slang shading language~~ [slang] Adding a package for the Slang shading language Jun 2, 2022

Merge branch 'upstream'

871fe7d

github-actions bot requested changes Jun 5, 2022

View reviewed changes

Merge remote-tracking branch 'origin/master'

458b73e

Merge branch 'upstream'

a016129

github-actions bot requested changes Jul 3, 2022

View reviewed changes

Merge branch 'upstream'

c6f0854

github-actions bot requested changes Jul 13, 2022

View reviewed changes

Merge remote-tracking branch 'origin/master'

fd8b111

github-actions bot requested changes Jul 23, 2022

View reviewed changes

Merge remote-tracking branch 'origin/master'

6a993b7

github-actions bot requested changes Aug 1, 2022

View reviewed changes

Merge remote-tracking branch 'origin/master'

016326f

github-actions bot requested changes Aug 2, 2022

View reviewed changes

Merge remote-tracking branch 'origin/master'

6867ac4

github-actions bot requested changes Aug 15, 2022

View reviewed changes

Merge remote-tracking branch 'origin/master'

e769638

github-actions bot requested changes Sep 2, 2022

View reviewed changes

Merge remote-tracking branch 'origin/master'

3d99355

github-actions bot requested changes Sep 8, 2022

View reviewed changes

Merge remote-tracking branch 'origin/master'

5f68e85

github-actions bot requested changes Sep 28, 2022

View reviewed changes

BillyONeal added 2 commits October 28, 2022 20:47

Merge remote-tracking branch 'origin/master' into HEAD

229ccbf

Use builtin VERSION and dos2unix.

ea452ff

BillyONeal dismissed stale reviews from JonLiu1993 and github-actions via ea452ff October 29, 2022 03:52

github-actions bot previously approved these changes Oct 29, 2022

View reviewed changes

BillyONeal requested changes Oct 29, 2022

View reviewed changes

BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Oct 29, 2022

djohansson added 2 commits October 30, 2022 18:00

remove unused empty folder policy

24eefa0

set version

c553971

djohansson dismissed github-actions’s stale review via c553971 October 30, 2022 17:02

update version

b73f476

github-actions bot requested changes Oct 30, 2022

View reviewed changes

github-actions bot previously approved these changes Oct 30, 2022

View reviewed changes

JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Oct 31, 2022

djohansson requested a review from BillyONeal October 31, 2022 14:12

Remove unnecessary set(VERSION

72ca0a2

BillyONeal dismissed stale reviews from github-actions and themself via 72ca0a2 October 31, 2022 20:18

BillyONeal previously approved these changes Oct 31, 2022

View reviewed changes

github-actions bot approved these changes Oct 31, 2022

View reviewed changes

BillyONeal merged commit bf6a6ce into microsoft:master Oct 31, 2022

BillyONeal mentioned this pull request Nov 1, 2022

Add vcpkg_minimum_required before using VERSION. #27598

Merged

dg0yt mentioned this pull request May 7, 2024

Add the Slang library #3372

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[slang] Adding a package for the Slang shading language #24914

[slang] Adding a package for the Slang shading language #24914

djohansson commented May 25, 2022 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

JonLiu1993 commented Jun 24, 2022

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

JonLiu1993 commented Oct 11, 2022

BillyONeal left a comment

BillyONeal Oct 29, 2022

djohansson Oct 31, 2022

BillyONeal commented Oct 29, 2022

BillyONeal commented Oct 29, 2022

github-actions bot left a comment

BillyONeal commented Oct 31, 2022

		@@ -0,0 +1,83 @@
		set(VCPKG_POLICY_EMPTY_INCLUDE_FOLDER enabled)

[slang] Adding a package for the Slang shading language #24914

[slang] Adding a package for the Slang shading language #24914

Conversation

djohansson commented May 25, 2022 • edited Loading

What does your PR fix?

Which triplets are supported/not supported? Have you updated the [CI baseline]

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

JonLiu1993 commented Jun 24, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

JonLiu1993 commented Oct 11, 2022

BillyONeal left a comment

Choose a reason for hiding this comment

BillyONeal Oct 29, 2022

Choose a reason for hiding this comment

djohansson Oct 31, 2022

Choose a reason for hiding this comment

BillyONeal commented Oct 29, 2022

BillyONeal commented Oct 29, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

BillyONeal commented Oct 31, 2022

djohansson commented May 25, 2022 •

edited

Loading

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?