[vowpal-wabbit] New port

[jackgerrits]

Describe the pull request

• What does your PR fix?

  This PR adds a port for the VowpalWabbit library

• Which triplets are supported/not supported? Have you updated the [CI baseline]

  I believe all should be supported except x86-windows. I am unsure about uwp though.

• Does your PR follow the maintainer guide?

  Yes

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

  Yes

Closes VowpalWabbit/vowpal_wabbit#2228

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout ce99c947b64ea3c0e274e18cc3035ca727681089 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index be790ae..0dd4892 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -7777,7 +7777,7 @@
       "port-version": 1
     },
     "vowpalwabbit": {
-      "baseline": "9.3.0",
+      "baseline": "9.5.0",
       "port-version": 0
     },
     "vs-yasm": {
diff --git a/versions/v-/vowpalwabbit.json b/versions/v-/vowpalwabbit.json
index deafc86..293d3c4 100644
--- a/versions/v-/vowpalwabbit.json
+++ b/versions/v-/vowpalwabbit.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "6b1205a5160128a40adf6714c5f9d6a38eaf1383",
+      "version": "9.5.0",
+      "port-version": 0
+    },
     {
       "git-tree": "6aac1bbc0bca774722db8ffd2b2b29c43676b5eb",
       "version": "9.3.0",

[jackgerrits]

I went ahead and marked arm64-windows as fail in the ci baseline file. If it's possible to see the log produced maybe it's an easy fix? I don't have access to a machine to test that configuration unfortunately though

[LilyWangLL]

If this port doesn't support x86-windows, please add supports in vcpkg.json and remove this code from ci.baseline.txt.

[jackgerrits]

Updated

[LilyWangLL]

Due to boost-random:x64-uwp build failed, so the uwp status of boost-math and this port on CI pipeline is cascade.

[LilyWangLL]

There are build error when build vowpalwabbit:arm64-windows, this port doesn't support arm64 too.
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.33.31629\include\xmmintrin.h(27): fatal error C1189: #error: This header is specific to X86, X64 and ARM64EC targets

[jackgerrits]

Marked arm+windows unsupported

[jackgerrits]

Thanks for the comments! I have marked the port as unsupported for x86, uwp and windows+arm.

[BillyONeal]

This is great, thank you! Can you check/confirm/fix the usage text? Then this is ready to merge!

vowpalwabbit

New port checklist:

• Review the code ✅
• Check the name against https://repology.org/ ⚠️
  No match, but there are Python and R bindings that appear to match.
• Check the name against Bing/Google. (If the first results aren't C++ related, try "name C++")
  First hit ✅
• Check the source code for optional find_packages
  GTest ✅, Threads ✅, Boost ✅, fmt ✅, spdlog ✅, RapidJson ✅, Boost ✅, Zlib ✅, Flatbuffers (Optional, but in vcpkg.json)
  JNI, Java skipped by BUILD_JAVA == off by default
  Boost, PythonXxx skipped by BUILD_PYTHON == off by default
• Check that the versioning scheme matches what upstream says ✅
• Check that the license in vcpkg.json matches what upstream says ✅
• Check that the license installed by the port matches what upstream says ✅
• Check that the source code comes from the upstream project's authoritative source. ✅
• Check that the generated usage is accurate.

vowpalwabbit provides CMake targets:

    # this is heuristically generated, and may not be correct
    find_package(VowpalWabbit CONFIG REQUIRED)
    # note: 4 additional targets are not displayed.
    target_link_libraries(main PRIVATE VowpalWabbit::vw_io VowpalWabbit::vw_core VowpalWabbit::vw_common VowpalWabbit::vw_config)

This seems not right due to the "4 additional targets skipped" ? I translated the heuristically generated result to a file for you, can you confirm what a user is supposed to do there? Thanks!

• Check for issues that are resolved. ✅

[BillyONeal]

(Blank usage would also be OK if that's what's appropriate)

[jackgerrits]

Thanks for the review!

• Check the name against https://repology.org/ ⚠️
  No match, but there are Python and R bindings that appear to match.

Thanks for checking this. You are right, the correct name in Repology is vowpal-wabbit. I will go ahead and update the port name to vowpal-wabbit to match.

Check that the generated usage is accurate.

It looks generally right, but I would like to go in and confirm myself what the 4 additional targets are prior to merging and remove any that potentially don't make sense.

I'll mention you here when I've resolved these two things.

[jackgerrits]

@BillyONeal I believe I've addressed the comments. A couple of the extra generated targets were for bins (that were previously deleted in the portfile), I added a patch to the port and created an issue in the upstream to address this (VowpalWabbit/vowpal_wabbit#4244).

I updated the usage file to explain the most common use case, those other targets are dependencies of the main one and are supporting libs.

[BillyONeal]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[BillyONeal]

Thanks for the new port!