Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X Window Part 9/N (some xcb ports) #27240

Merged
merged 19 commits into from
Oct 26, 2022
Merged

Conversation

Neumann-A
Copy link
Contributor

No description provided.

github-actions[bot]
github-actions bot previously approved these changes Oct 14, 2022
github-actions[bot]
github-actions bot previously approved these changes Oct 14, 2022
@Adela0814 Adela0814 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 17, 2022
Adela0814
Adela0814 previously approved these changes Oct 18, 2022
@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Oct 18, 2022
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nitpicks and questions, overall this looks good, thanks!

xcb-errors xcb-image xcb-keysyms xcb-util xcb-wm

New port checklist:

  • Review the code ⚠️⚠️⚠️⚠️⚠️

  • Check the name against https://repology.org/ ❗✅✅✅❗
    Should xcb-errors be xcb-util-errors ? https://repology.org/project/xcb-util-errors/versions
    Should xcb-wm be xcb-util-wm ? https://repology.org/project/xcb-util-wm/versions

  • Check the name against Bing/Google. (If the first results aren't C++ related, try "name C++") Skipped.

  • Check the source code for optional find_packages None are CMake. ✅

  • Check that the versioning scheme matches what upstream says ✅✅✅✅✅

  • Check that the license in vcpkg.json matches what upstream says ✅✅✅✅✅

  • Check that the license installed by the port matches what upstream says ✅⚠️✅✅✅

  • Check that the source code comes from the upstream project's authoritative source. ✅✅✅✅✅

  • Check that the generated usage is accurate. No usage. ✅

  • Check for issues that are resolved. ✅✅✅✅✅ (No hits for "xcb")

ports/xcb-errors/fix_python.patch Outdated Show resolved Hide resolved
ports/xcb-image/add_return_value.patch Show resolved Hide resolved
ports/xcb-wm/build.patch Outdated Show resolved Hide resolved
ports/xcb-util/ssize.patch Outdated Show resolved Hide resolved
ports/xcb-errors/portfile.cmake Outdated Show resolved Hide resolved
ports/xcb-image/portfile.cmake Outdated Show resolved Hide resolved
ports/xcb-keysyms/portfile.cmake Outdated Show resolved Hide resolved
ports/xcb-util/portfile.cmake Outdated Show resolved Hide resolved
ports/xcb-wm/portfile.cmake Outdated Show resolved Hide resolved
@BillyONeal BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Oct 20, 2022
Co-authored-by: Billy O'Neal <bion@microsoft.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for xcb-keysyms have changed but the version was not updated
version: 0.4.0
old SHA: 3b58993d153b991cd41e75ec45fc0741a6c4b159
new SHA: 9c1f85139ab35abaabdc575fa4d91d5a820ee730
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for xcb-util have changed but the version was not updated
version: 0.4.0
old SHA: 0c09f15c42dec14a7c0276079dd9ce711cad5623
new SHA: 0b2dd28a457c5d2458abc8a8d342ecdfd018ef2a
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for xcb-errors have changed but the version was not updated
version: 1.0
old SHA: eb53667b3debd4012a4b12ed904c2c148f73b376
new SHA: 93127fabff5d1db48f6685485ac3aee29cab4344
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for xcb-image have changed but the version was not updated
version: 0.4.0
old SHA: 0308ff836b0bebda6b9f9a08400363f750d55301
new SHA: 9c2051de81b668fcd86b8da90231eb0fd7c1bbf7
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for xcb-wm have changed but the version was not updated
version: 0.4.1
old SHA: 6b384497e888ccba54bc2079c80284f40b476b19
new SHA: 9a0a48250ce3ca752517606ace4a51d94e85c05e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Oct 20, 2022
github-actions[bot]
github-actions bot previously approved these changes Oct 20, 2022
github-actions[bot]
github-actions bot previously approved these changes Oct 20, 2022
@Neumann-A
Copy link
Contributor Author

Should xcb-errors be xcb-util-errors ? https://repology.org/project/xcb-util-errors/versions
Should xcb-wm be xcb-util-wm ? https://repology.org/project/xcb-util-wm/versions

there doesn't seem to be a consistent naming for these. The repos are libxcb-errors / libxcb-wm. On Cygwin is split up into the two sub libs (iccm,ewmh) in libxcb-wm.

The pc file for xcb-errors is https://gitlab.freedesktop.org/xorg/lib/libxcb-errors/-/blob/master/xcb-errors.pc.in

github-actions[bot]
github-actions bot previously approved these changes Oct 21, 2022
@Neumann-A
Copy link
Contributor Author

@Adela0814 Please remove requires:author-response.

@Adela0814 Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Oct 25, 2022
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! <3

@BillyONeal BillyONeal merged commit 4aedc13 into microsoft:master Oct 26, 2022
@Neumann-A Neumann-A deleted the x_window_part9 branch October 26, 2022 05:11
BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Nov 1, 2022
…0-17, he started applying use of the "embedded VERSION" feature microsoft/vcpkg-tool#717 to PRs on merge.

@dg0yt points out that this use should be accompanied by a call to vcpkg_minimum_required, in https://github.com/microsoft/vcpkg/pull/27594/files#r1010641672

This is an audit of everything merged in that time and whether it needs to gain that.

microsoft#27561 No VERSION
microsoft#27525 No VERSION
microsoft#27554 Already has vcpkg_minimum_required
microsoft#27536 No VERSION
microsoft#27562 No VERSION
microsoft#24914 Fixed here
microsoft#27547 No VERSION
microsoft#27502 No VERSION
microsoft#27497 No VERSION
microsoft#27317 No VERSION
microsoft#27288 No VERSION
microsoft#27509 No VERSION
microsoft#27504 No VERSION
microsoft#27514 No VERSION
microsoft#27501 No VERSION
microsoft#27495 No VERSION
microsoft#27488 No VERSION
microsoft#27499 No VERSION
microsoft#27378 No VERSION
microsoft#27376 Fixed here
microsoft#27373 No VERSION
microsoft#27045 No VERSION
microsoft#27521 No VERSION
microsoft#27453 No VERSION
microsoft#27481 No VERSION
microsoft#27511 No VERSION
microsoft#27490 No VERSION
microsoft#27510 No VERSION
microsoft#27496 No VERSION
microsoft#27503 No VERSION
microsoft#27485 No VERSION
microsoft#27484 No VERSION
microsoft#27483 No VERSION
microsoft#27459 No VERSION
microsoft#27369 No VERSION
microsoft#27489 No VERSION
microsoft#26594 No VERSION
microsoft#27465 No VERSION
microsoft#27456 No VERSION
microsoft#27425 No VERSION
microsoft#27464 Fixed here
microsoft#27406 No VERSION
microsoft#27398 No VERSION
microsoft#27240 No VERSION
microsoft#27450 No VERSION
microsoft#27463 No VERSION
microsoft#27462 No VERSION
microsoft#27448 No VERSION
microsoft#27440 No VERSION
microsoft#27435 No VERSION
microsoft#27424 No VERSION
microsoft#27414 No VERSION
microsoft#27412 No VERSION
microsoft#27380 No VERSION
microsoft#27343 No VERSION
microsoft#27342 No VERSION
microsoft#27367 No VERSION
microsoft#27226 No VERSION
microsoft#27320 No VERSION
microsoft#26923 No VERSION
microsoft#27284 No VERSION
microsoft#27433 No VERSION
microsoft#27314 VERSION got *removed*
microsoft#27335 No VERSION
microsoft#27370 No VERSION
microsoft#27324 No VERSION
microsoft#27391 No VERSION
microsoft#27388 No VERSION
microsoft#27396 No VERSION
microsoft#27404 No VERSION
microsoft#27413 No VERSION
microsoft#27417 No VERSION
microsoft#27427 No VERSION
microsoft#27428 No VERSION
microsoft#27368 No VERSION
microsoft#27307 No VERSION
microsoft#27415 Fixed here.
microsoft#27371 Fixed here.
microsoft#27323 No VERSION
microsoft#27352 No VERSION
microsoft#27347 No VERSION
microsoft#27366 No VERSION
microsoft#27361 No VERSION
microsoft#27359 No VERSION
microsoft#27358 No VERSION
microsoft#27355 No VERSION
microsoft#27331 No VERSION
microsoft#24615 No VERSION
microsoft#27325 No VERSION
microsoft#24861 No VERSION
microsoft#27354 No VERSION
microsoft#27346 No VERSION
microsoft#27345 No VERSION
microsoft#27218 No VERSION
microsoft#27329 No VERSION
microsoft#27326 No VERSION
microsoft#27321 No VERSION
microsoft#27312 No VERSION
microsoft#27297 No VERSION
microsoft#27336 No VERSION
microsoft#27225 No VERSION
microsoft#27339 No VERSION
microsoft#27302 No VERSION
microsoft#27295 No VERSION
microsoft#27233 No VERSION
microsoft#27313 No VERSION
microsoft#27237 No VERSION
microsoft#27250 No VERSION
microsoft#27263 No VERSION
microsoft#27266 No VERSION
microsoft#27272 No VERSION
microsoft#27287 No VERSION
microsoft#27282 No VERSION
microsoft#27294 No VERSION
microsoft#27228 No VERSION
microsoft#27163 No VERSION
microsoft#26817 No VERSION
microsoft#27286 No VERSION
microsoft#27274 No VERSION
microsoft#27276 No VERSION
microsoft#27232 No VERSION
microsoft#27221 No VERSION
microsoft#27215 No VERSION
microsoft#27166 No VERSION
microsoft#27239 No VERSION
microsoft#27246 No VERSION
microsoft#27268 No VERSION
microsoft#27259 No VERSION
microsoft#27238 No VERSION
microsoft#27224 No VERSION
microsoft#27203 No VERSION
microsoft#27124 No VERSION
JavierMatosD pushed a commit that referenced this pull request Nov 8, 2022
* When @BillyONeal started being the on-call vcpkg maintainer on 2022-10-17, he started applying use of the "embedded VERSION" feature microsoft/vcpkg-tool#717 to PRs on merge.

@dg0yt points out that this use should be accompanied by a call to vcpkg_minimum_required, in https://github.com/microsoft/vcpkg/pull/27594/files#r1010641672

This is an audit of everything merged in that time and whether it needs to gain that.

#27561 No VERSION
#27525 No VERSION
#27554 Already has vcpkg_minimum_required
#27536 No VERSION
#27562 No VERSION
#24914 Fixed here
#27547 No VERSION
#27502 No VERSION
#27497 No VERSION
#27317 No VERSION
#27288 No VERSION
#27509 No VERSION
#27504 No VERSION
#27514 No VERSION
#27501 No VERSION
#27495 No VERSION
#27488 No VERSION
#27499 No VERSION
#27378 No VERSION
#27376 Fixed here
#27373 No VERSION
#27045 No VERSION
#27521 No VERSION
#27453 No VERSION
#27481 No VERSION
#27511 No VERSION
#27490 No VERSION
#27510 No VERSION
#27496 No VERSION
#27503 No VERSION
#27485 No VERSION
#27484 No VERSION
#27483 No VERSION
#27459 No VERSION
#27369 No VERSION
#27489 No VERSION
#26594 No VERSION
#27465 No VERSION
#27456 No VERSION
#27425 No VERSION
#27464 Fixed here
#27406 No VERSION
#27398 No VERSION
#27240 No VERSION
#27450 No VERSION
#27463 No VERSION
#27462 No VERSION
#27448 No VERSION
#27440 No VERSION
#27435 No VERSION
#27424 No VERSION
#27414 No VERSION
#27412 No VERSION
#27380 No VERSION
#27343 No VERSION
#27342 No VERSION
#27367 No VERSION
#27226 No VERSION
#27320 No VERSION
#26923 No VERSION
#27284 No VERSION
#27433 No VERSION
#27314 VERSION got *removed*
#27335 No VERSION
#27370 No VERSION
#27324 No VERSION
#27391 No VERSION
#27388 No VERSION
#27396 No VERSION
#27404 No VERSION
#27413 No VERSION
#27417 No VERSION
#27427 No VERSION
#27428 No VERSION
#27368 No VERSION
#27307 No VERSION
#27415 Fixed here.
#27371 Fixed here.
#27323 No VERSION
#27352 No VERSION
#27347 No VERSION
#27366 No VERSION
#27361 No VERSION
#27359 No VERSION
#27358 No VERSION
#27355 No VERSION
#27331 No VERSION
#24615 No VERSION
#27325 No VERSION
#24861 No VERSION
#27354 No VERSION
#27346 No VERSION
#27345 No VERSION
#27218 No VERSION
#27329 No VERSION
#27326 No VERSION
#27321 No VERSION
#27312 No VERSION
#27297 No VERSION
#27336 No VERSION
#27225 No VERSION
#27339 No VERSION
#27302 No VERSION
#27295 No VERSION
#27233 No VERSION
#27313 No VERSION
#27237 No VERSION
#27250 No VERSION
#27263 No VERSION
#27266 No VERSION
#27272 No VERSION
#27287 No VERSION
#27282 No VERSION
#27294 No VERSION
#27228 No VERSION
#27163 No VERSION
#26817 No VERSION
#27286 No VERSION
#27274 No VERSION
#27276 No VERSION
#27232 No VERSION
#27221 No VERSION
#27215 No VERSION
#27166 No VERSION
#27239 No VERSION
#27246 No VERSION
#27268 No VERSION
#27259 No VERSION
#27238 No VERSION
#27224 No VERSION
#27203 No VERSION
#27124 No VERSION

* Also add libcanberra
BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Feb 2, 2023
That SHA512 is for 24eb17df2e1245885e72c9d4bbb0a0f69f0700f2, which was 0.4.1, not 0c6681e465c9cc7b1fbb60778ba1eaa61ab01a14 which is 0.4.2.

This was probably just done wrong originally in microsoft#27240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants