Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new port] at-spi2-atk 2.38.0 port #26766

Merged
merged 2 commits into from
Sep 28, 2022
Merged

[new port] at-spi2-atk 2.38.0 port #26766

merged 2 commits into from
Sep 28, 2022

Conversation

mkhon
Copy link
Contributor

@mkhon mkhon commented Sep 12, 2022 •
edited
Loading

at-spi2-atk 2.38.0 port
at-spi2-core 2.44.1 port

Describe the pull request

  • What does your PR fix?

The port provides at-spi2-atk dependency needed by gtk3

  • Which triplets are supported/not supported? Have you updated the CI baseline?

linux

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@mkhon
at-spi2-atk 2.38.0 port
eba135d 
at-spi2-core 2.44.1 port
@mkhon mkhon mentioned this pull request Sep 12, 2022
Closed
@mkhon mkhon changed the title at-spi2-atk 2.38.0 port [new port] at-spi2-atk 2.38.0 port Sep 12, 2022
@mkhon
Copy link
Contributor Author

mkhon commented Sep 12, 2022

@BillyONeal @talregev can we please continue here?

@talregev
Copy link
Contributor

Why you open a new one?
@mkhon Please don't tag me if you don't respond my comment.

@mkhon
Copy link
Contributor Author

mkhon commented Sep 12, 2022 •
edited
Loading

Why you open a new one?
@mkhon Please don't tag me if you don't respond my comment.

Because all my previous PRs were made from the vcpkg fork owned by an organization. github does provide an option 'Allow edits by maintainers' for org-owned forks.

@talregev
Copy link
Contributor

@JackBoosY @BillyONeal
Now you have access to this PR.
Please help to fix the missing library problem: libxtst
Thank you in advanced.

@talregev
Copy link
Contributor

talregev commented Sep 12, 2022 •
edited
Loading

Why you open a new one?
@mkhon Please don't tag me if you don't respond my comment.

Because all my previous PRs were made from the vcpkg fork owned by an organization. github does provide an option 'Allow edits by maintainers' for org-owned forks.

Why you didn't do it earlier? You understand that your pervious PRs is slowed the productive? Now not sure how much people have energy to continue and help on this PR.

@mkhon
Copy link
Contributor Author

mkhon commented Sep 12, 2022

Why you open a new one?
@mkhon Please don't tag me if you don't respond my comment.

Because all my previous PRs were made from the vcpkg fork owned by an organization. github does provide an option 'Allow edits by maintainers' for org-owned forks.

Why you didn't do it earlier? You understand that your pervious PRs is slowed the productive? Now not sure how much people have energy to continue and help on this PR.

Because I do it in my free time and the speed of PR review and feedback was less than adequate. Do you know for how long gtk3 PR is not merged (and there was no any need for maintainer edits there)? This is rather frustrating at least.

@talregev
Copy link
Contributor

talregev commented Sep 12, 2022 •
edited
Loading

Why you open a new one?
@mkhon Please don't tag me if you don't respond my comment.

Because all my previous PRs were made from the vcpkg fork owned by an organization. github does provide an option 'Allow edits by maintainers' for org-owned forks.

Why you didn't do it earlier? You understand that your pervious PRs is slowed the productive? Now not sure how much people have energy to continue and help on this PR.

Because I do it in my free time and the speed of PR review and feedback was less than adequate. Do you know for how long gtk3 PR is not merged (and there was no any need for maintainer edits there)? This is rather frustrating at least.

Also frustrating for me. But beside the things happen in vcpkg, also the speed of comments and lack of edit the PRs, dev are slowed very much.
And I thank you that you your time and effort to make these PRs. I understand your frustrating , because I also contribute to open source and vcpkg, and I know how it be like to be in your position.

@JonLiu1993 JonLiu1993 self-assigned this Sep 13, 2022
@JackBoosY JackBoosY self-assigned this Sep 13, 2022
@JackBoosY JackBoosY added depends:vm-update PR contains changes to the VM provisioning scripts category:new-port The issue is requesting a new library to be added; consider making a PR! labels Sep 13, 2022
@JackBoosY JackBoosY mentioned this pull request Sep 16, 2022
Closed
@talregev
Copy link
Contributor

@JackBoosY vm September was merge. Please merge the master to here. Thanks!

@BillyONeal BillyONeal removed the depends:vm-update PR contains changes to the VM provisioning scripts label Sep 26, 2022
@BillyONeal
Copy link
Member

@JackBoosY vm September was merge. Please merge the master to here. Thanks!

puts on JackBoosY mask
merges with master
takes JackBoosY mask back off

:)

@talregev
Copy link
Contributor

@BillyONeal Can you put @JackBoosY mask again and review this PR? :)

@BillyONeal
Copy link
Member

@BillyONeal Can you put @JackBoosY mask again and review this PR? :)

What is this, Utawarerumono? In all seriousness, I think review of new ports should go through the usual channels.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Sep 28, 2022
@vicroms vicroms merged commit 51685e1 into microsoft:master Sep 28, 2022
@mkhon mkhon deleted the feature/at-spi2-atk branch September 28, 2022 19:00
@autoantwort
Copy link
Contributor

autoantwort commented Oct 1, 2022 •
edited
Loading

This port contains an absolute path :(
Search here for absolute paths

@talregev
Copy link
Contributor

talregev commented Oct 2, 2022

This port contains an absolute path :( Search here for absolute paths

@mkhon @JackBoosY @dg0yt
Can you solve it?

@talregev
Copy link
Contributor

talregev commented Oct 2, 2022

@autoantwort Please open an issue about this.

@Neumann-A
Copy link
Contributor

Hmm was the xtst dependency actually required? Could probably be just for the tests which could have been easily patched out...

@talregev
Copy link
Contributor

Hmm was the xtst dependency actually required?

Yes, we waited several months (more then half year) until it added to vm.

@dg0yt
Copy link
Contributor

dg0yt commented Oct 21, 2022

Hmm was the xtst dependency actually required? Could probably be just for the tests which could have been easily patched out...

No, this "assistive technology" really uses these interface for X11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal left review comments

@talregev talregev talregev left review comments

@github-actions GitHub Actions github-actions approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

@JonLiu1993 JonLiu1993

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@mkhon @talregev @BillyONeal @autoantwort @Neumann-A @dg0yt @JackBoosY @vicroms @JonLiu1993