Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openexr] Update from 2 to 3.1.5, patch all consuming ports #26862

Merged
merged 14 commits into from
Sep 26, 2022

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Sep 18, 2022

@JonLiu1993 JonLiu1993 self-assigned this Sep 19, 2022
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Sep 19, 2022
@dg0yt
Copy link
Contributor Author

dg0yt commented Sep 19, 2022

What to do with /guard:ehcont as used by directxtex, but absent in openexr?
a) Disabled it where used (directxtex (done), uvatlas (current error))
b) Add it upstream where necessary (at least openexr, imath)

Note that this problem is not a regression, but was already hidden behind optional directxtex[openexr]. It is just uncovered by specific test commits.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/ilmbase/vcpkg.json
  • ports/pangolin/vcpkg.json

Valid values for the license field can be found in the documentation

@meshula
Copy link

meshula commented Sep 19, 2022

Thank you for this patch! Looking forward to being able to use it :)

@JonLiu1993 JonLiu1993 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Sep 20, 2022
@JonLiu1993
Copy link
Member

All features are tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Sep 20, 2022
@dan-shaw dan-shaw added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Sep 21, 2022
@simogasp
Copy link
Contributor

Great work! thanks for this.
If it can be merged I will close my draft #25238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants