[boost-vcpkg-helpers] Fix incorrect license #28617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyWangLL
added
category:port-bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dg0yt
approved these changes
Dec 29, 2022
| DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}" | ||
| ) | ||
|
|
||
| vcpkg_install_copyright(FILE_LIST "${CMAKE_CURRENT_LIST_DIR}/LICENSE.txt") |
There was a problem hiding this comment.
- making
share/${PORT}/copyrightmatch the port's license, MIT.
Comment on lines
+20
to
+23
| file(INSTALL | ||
| "${CURRENT_INSTALLED_DIR}/share/boost-vcpkg-helpers/boost_LICENSE_1_0.txt" | ||
| DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}" | ||
| RENAME copyright |
There was a problem hiding this comment.
- using a different path for the boost copyright template file.
MonicaLiu0311
approved these changes
Dec 30, 2022
MonicaLiu0311
added
the
info:reviewed
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Jan 31, 2023
Added the ability for the 'default' port version to get a value in case they all change at once (as almost happened due to microsoft#29288) microsoft#28356 did not apply post-source stubs for url and locale. I suspect they were just forgotten to be checked in? microsoft#28617 did not record the port version change in generate-ports.ps1. Also fixed all files to have LF line endings. (since changing boost-vcpkg-helper version also changed all the other ports anyway) Also changed "When changing this file also update and run scripts/boost/generate-ports.ps1" to "Automatically generated by scripts/boost/generate-ports.ps1" because I think that better conveys the consequences (your changes will get nuked).
BillyONeal
added a commit
that referenced
this pull request
Feb 1, 2023
Added the ability for the 'default' port version to get a value in case they all change at once (as almost happened due to #29288) #28356 did not apply post-source stubs for url and locale. I suspect they were just forgotten to be checked in? #28617 did not record the port version change in generate-ports.ps1. Also fixed all files to have LF line endings. (since changing boost-vcpkg-helper version also changed all the other ports anyway) Also changed "When changing this file also update and run scripts/boost/generate-ports.ps1" to "Automatically generated by scripts/boost/generate-ports.ps1" because I think that better conveys the consequences (your changes will get nuked).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes [boost-vcpkg-helpers] Has inconsistent copyright info #27067, add MIT license file forboost-vcpkg-helpers.