-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[boost-vcpkg-helpers] Has inconsistent copyright info #27067
Comments
MIT in the manifest is correct here since the port is just a script port. |
I would expect it to then install MIT |
The license should be |
@JackBoosY: why? This is a script helper port and has nothing to do with boost.... Did you only look at the downloaded license? |
Reasonable. That's just a helper, the author is us, not boost. |
@horenmar |
IMO the issue shouldn't be closed but resolved as proposed by
|
Yep. The issue afaik still persists, in that there is inconsistent The current state is annoying in that it trips up error checking in our license-notice stitch script, because the detected copyrights are inconsistent. |
I submitted PR #28617 to fix this issue, I copy the MIT license file in vcpkg to [VCPKG_ROOT]/ports/boost-vcpkg-helpers. Also modify the |
Great, thanks. |
The
boost-vcpkg-helpers
license declaration is inconsistent. The portfile downloads BSL copyright notice but the vcpkg.json declares MIT license.Proposed solution
Make them consistent. I don't know which license is correct though.
The text was updated successfully, but these errors were encountered: