Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boost-vcpkg-helpers] Has inconsistent copyright info #27067

Closed
horenmar opened this issue Oct 2, 2022 · 10 comments · Fixed by #28617
Closed

[boost-vcpkg-helpers] Has inconsistent copyright info #27067

horenmar opened this issue Oct 2, 2022 · 10 comments · Fixed by #28617
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@horenmar
Copy link
Contributor

horenmar commented Oct 2, 2022

The boost-vcpkg-helpers license declaration is inconsistent. The portfile downloads BSL copyright notice but the vcpkg.json declares MIT license.

Proposed solution
Make them consistent. I don't know which license is correct though.

@Neumann-A
Copy link
Contributor

MIT in the manifest is correct here since the port is just a script port.
It uses the downloaded copyright to install it for all header based libraries without having to rename the file.

@horenmar
Copy link
Contributor Author

horenmar commented Oct 4, 2022

I would expect it to then install MIT copyright file into its own folder then.

@JackBoosY
Copy link
Contributor

The license should be BSL-1.0.

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Oct 8, 2022
@Neumann-A
Copy link
Contributor

The license should be BSL-1.0.

@JackBoosY: why? This is a script helper port and has nothing to do with boost.... Did you only look at the downloaded license?

@JackBoosY
Copy link
Contributor

The license should be BSL-1.0.

@JackBoosY: why? This is a script helper port and has nothing to do with boost.... Did you only look at the downloaded license?

Reasonable. That's just a helper, the author is us, not boost.

@JackBoosY JackBoosY added category:question This issue is a question and removed category:port-bug The issue is with a library, which is something the port should already support labels Oct 8, 2022
@MonicaLiu0311
Copy link
Contributor

@horenmar
This is a script helper port and has nothing to do with boost, can this issue be closed?

@dg0yt
Copy link
Contributor

dg0yt commented Oct 24, 2022

IMO the issue shouldn't be closed but resolved as proposed by

  • making share/${PORT}/copyright match the ports license, MIT.
  • using a different path for the boost copyright template file.

@horenmar
Copy link
Contributor Author

Yep. The issue afaik still persists, in that there is inconsistent copyright file and spdx expression in the port. I don't care whether the port is also licensed under BSL or the port is changed to download MIT copyright file.

The current state is annoying in that it trips up error checking in our license-notice stitch script, because the detected copyrights are inconsistent.

@JackBoosY JackBoosY removed their assignment Oct 27, 2022
@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support and removed category:question This issue is a question labels Dec 29, 2022
@LilyWangLL
Copy link
Contributor

I submitted PR #28617 to fix this issue, I copy the MIT license file in vcpkg to [VCPKG_ROOT]/ports/boost-vcpkg-helpers. Also modify the boost-modular-headers.cmake to make other boost ports still use boost licnese.

@horenmar
Copy link
Contributor Author

horenmar commented Jan 4, 2023

Great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
6 participants