-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[icu] Fix #30532: trying to set rpath on missing libicutu #30544
Merged
BillyONeal
merged 4 commits into
microsoft:master
from
janisozaur:icu-dynamic-no-libicutu
Apr 12, 2023
Merged
[icu] Fix #30532: trying to set rpath on missing libicutu #30544
BillyONeal
merged 4 commits into
microsoft:master
from
janisozaur:icu-dynamic-no-libicutu
Apr 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft#29196 introduced new feature flag `[tools]` which prevents generation of `libicutu`. The PR in question did not take into account dynamic linkage target where rpath is set to hardcoded and no longer valid list of libraries. This PR dynamically detects presence of `[tools]` feature and adds `libicutu` for rpath fix as necessary.
b009cff
to
ac80fda
Compare
Depends on #30546 |
I plan to do a release that would benefit from this PR, can I expect this to be merged today? I can see #30456 which you mentioned is already approved and has all the checks green |
…dynamic-no-libicutu
…dynamic-no-libicutu
…dynamic-no-libicutu
MonicaLiu0311
approved these changes
Apr 12, 2023
Feature |
Thanks! |
This was referenced Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-bug
The issue is with a library, which is something the port should already support
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29196 introduced new feature flag
[tools]
which prevents generation oflibicutu
. The PR in question did not take into account dynamic linkage target where rpath is set to hardcoded and no longer valid list of libraries.This PR dynamically detects presence of
[tools]
feature and addslibicutu
for rpath fix as necessary.Fixes #30532
./vcpkg x-add-version --all
and committing the result.