Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[icu] Add tools, fix building for ios #29196

Merged
merged 3 commits into from
Jan 27, 2023
Merged

[icu] Add tools, fix building for ios #29196

merged 3 commits into from
Jan 27, 2023

Conversation

m-kuhn
Copy link
Contributor

@m-kuhn m-kuhn commented Jan 26, 2023

Fixes #26727

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

github-actions[bot]
github-actions bot previously approved these changes Jan 26, 2023
View reviewed changes
@BillyONeal BillyONeal added the info:reviewed Pull Request changes follow basic guidelines label Jan 27, 2023
@BillyONeal
Copy link
Member

Thanks for the feature add!

@BillyONeal BillyONeal added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jan 27, 2023
@BillyONeal BillyONeal merged commit cdbcc03 into microsoft:master Jan 27, 2023
@m-kuhn m-kuhn deleted the ios_icu branch January 27, 2023 05:54
@MonicaLiu0311 MonicaLiu0311 mentioned this pull request Jan 28, 2023
Closed
@Chlumsky Chlumsky mentioned this pull request Jan 31, 2023
Closed
@xiaozhuai xiaozhuai mentioned this pull request Feb 6, 2023
Closed
21 tasks
@janisozaur janisozaur mentioned this pull request Mar 30, 2023
Closed
@janisozaur janisozaur mentioned this pull request Mar 30, 2023
Merged
7 tasks
janisozaur added a commit to janisozaur/vcpkg that referenced this pull request Mar 30, 2023
@janisozaur
[icu] Fix microsoft#30532: trying to set rpath on missing libicutu
ac80fda 
microsoft#29196 introduced new feature flag `[tools]` which
prevents generation of `libicutu`. The PR in question did not take into
account dynamic linkage target where rpath is set to hardcoded and no
longer valid list of libraries.

This PR dynamically detects presence of `[tools]` feature and adds
`libicutu` for rpath fix as necessary.
BillyONeal pushed a commit that referenced this pull request Apr 12, 2023
@janisozaur
[icu] Fix #30532: trying to set rpath on missing libicutu (#30544)
4f9d25a 
#29196 introduced new feature flag `[tools]` which
prevents generation of `libicutu`. The PR in question did not take into
account dynamic linkage target where rpath is set to hardcoded and no
longer valid list of libraries.

This PR dynamically detects presence of `[tools]` feature and adds
`libicutu` for rpath fix as necessary.

Co-authored-by: Monica <v-liumonica@microsoft.com>
@IRebo IRebo mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees
No one assigned
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ICU] build failure arm64-ios
2 participants
@m-kuhn @BillyONeal