-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openimageio] Skip building tests #30570
[openimageio] Skip building tests #30570
Conversation
This may hide the problem when building openimageio. But at that point the intel-mlk dependency has already made its way into the binaries. So it will eventually hit downstreams. In addition, the problem can be in another port. There is no hint that openimageio picks intel-mkl. The context points at opencv4. |
Log from
|
I already took my arguments from CI's set of openimageio logs. I checked the config and CMakeCache log files before posting. So let me repeat the conclusion: There is no hint that openimageio picks intel-mkl. The context points at opencv4. To clarify: There is no observable config step in openimageio that picks intel-mkl. It is just passed through as a transitive dependency, in non-cached variables. In the build step, the intel-mkl libs appear next to opencv4 libs. |
To verify that, I suggest running a build of openimageio with |
Run the command: The log is as follows: @dg0yt Do you have any good suggestions? Thanks in advance. |
|
@dg0yt Yes, I have done that, I found that both ways have the same effect, the log is as above. |
I only get an empty file when I try to download the config log linked in #30570 (comment). |
! 😅 ...replaced by |
Hm, 12 MB, but no pointers to intel mkl. |
I think what is going on is that #29437 now installs and makes available And once again everyone wanting to provide BLAS/Lapack curb stomps our face. |
That happens if you dont lock-in the blas/lapack vendor although the dep logic requires it. There is a reason #24327 exists |
Unless port (vcpkg also can't wrap |
@BillyONeal |
I agree with @dg0yt that this is probably hiding a problem, but not building tests is consistently something we consider a good thing so I think we should take this regardless of how we slay the blas/lapack monster. |
Related: microsoft#30570. Alternative to: microsoft#30754.
Despite offering a competing resolution of the problem in #30883 I'm merging this because we generally consider not building tests something ports should be doing, and I think it has value from that aspect alone. Thanks for digging and sorry running this down was so painful @MonicaLiu0311 :) |
Disable the option
OIIO_BUILD_TESTS
to fix the following errors:Repro steps:
SHA512s are updated for each updated downloadThe "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.