-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg baseline][opencv4] Control intel-mkl dependency #30754
Conversation
Sadly I think this is an alternative :( |
I don't think this fix is correct. opencv should be listening to what the blas and lapack metaports say in order to determine which blas/lapack to use, and shouldn't really be controlling something that is an alternative like this with the feature mechanism. I'm looking at a fix now. |
I think the right fix is to always pass |
I cannot check the details soon, but I tend to agree that the mkl feature shouldn't be there. |
Related: microsoft#30570. Alternative to: microsoft#30754.
OK, I validated that that change actually fixes the problem and have submitted a competing proposal here: #30883 |
Replaced by #30883. |
Assumed to fix the openimagio:x64-linux CI baseline regression, given the
<opencv4 libs> <intel-mkl libs>
argument sequence of the failing link step.(This PR is just to resolve the baseline regression without completely disabling intel-mkl for opencv4, not to ensure that opencv4[mkl] correctly exports link libraries for downstream usage as in openimagio.)
Related: #30570.
./vcpkg x-add-version --all
and committing the result.