Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[etcd-cpp-apiv3] update to 0.15.3 #32747

Merged
merged 17 commits into from
Jul 27, 2023
Merged

[etcd-cpp-apiv3] update to 0.15.3 #32747

merged 17 commits into from
Jul 27, 2023

Conversation

JonLiu1993
Copy link
Member

@JonLiu1993 JonLiu1993 commented Jul 25, 2023 •
edited
Loading

Fixes #32666

Update port etcd-cpp-apiv3 the latest version 0.15.3
Fix error:

fatal error LNK1107: invalid or corrupt file: cannot read at 0x330

Fix error :

error: use of undeclared identifier 'IPPROTO_TCP'

Note: no feature need to test.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@JonLiu1993 JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Jul 25, 2023
@JonLiu1993 JonLiu1993 marked this pull request as ready for review July 26, 2023 03:00
BillyONeal
BillyONeal previously approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you submit these patches upstream?

@JonLiu1993 JonLiu1993 mentioned this pull request Jul 27, 2023
Merged
@JonLiu1993
Copy link
Member Author

Can you submit these patches upstream?

Thank you for the reminder, I have submitted a PR #244 on Upstream.

sighingnow added a commit to etcd-cpp-apiv3/etcd-cpp-apiv3 that referenced this pull request Jul 27, 2023
@JonLiu1993 @sighingnow
Fix error LNK1107 and undeclared identifier 'IPPROTO_TCP' (#244)
e5dc903 
When I [Update](microsoft/vcpkg#32747)
etcd-cpp-apiv3 version from 0.14.2 to 0.15.2, I get two build error:
````
fatal error LNK1107: invalid or corrupt file: cannot read at 0x330
````
````
error: use of undeclared identifier 'IPPROTO_TCP'
````

The first error was because the target `etcd-cpp-api-core-objects`
linked the wrong `libprotobufd.dll` file instead of the .lib file, I
used the usage provided by vcpkg to link the correct .lib file to fix
this error.

Another error was because `IPPROTO_TCP` was missing declaration
`"<netinet/in.h>"`, I added it to fix this error.

---------

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Co-authored-by: Zhao Liu <v-zhli17@microsoft.com>
Co-authored-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow
Copy link
Contributor

sighingnow commented Jul 27, 2023 •
edited
Loading

Hi @JonLiu1993 The pull request on etcd-cpp-apiv3 has been merged and I have just cut a new release v0.15.3, please use that version in vcpkg.

Thanks!

@JonLiu1993 JonLiu1993 changed the title [etcd-cpp-apiv3] update to 0.15.2 [etcd-cpp-apiv3] update to 0.15.3 Jul 27, 2023
@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Jul 27, 2023
@BillyONeal BillyONeal merged commit d523304 into microsoft:master Jul 27, 2023
15 checks passed
@BillyONeal
Copy link
Member

Thanks for the update and following up with upstream!

@JonLiu1993 JonLiu1993 deleted the dev/Jon/etcd-cpp-apiv3 branch July 28, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@Adela0814 Adela0814 Adela0814 approved these changes

@BillyONeal BillyONeal BillyONeal left review comments

Assignees

@Adela0814 Adela0814

Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[etcd-cpp-apiv3] update to 0.15.2
5 participants
@JonLiu1993 @sighingnow @BillyONeal @dg0yt @Adela0814