[gtk/gtk3] Fix install gschemas.compiled of glib-2.0 #33253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyWangLL
added
category:port-feature
LilyWangLL
changed the title
Cheney-W
previously approved these changes
Aug 21, 2023
dg0yt
suggested changes
Aug 21, 2023
There was a problem hiding this comment.
I think this PR is invalid, due to misunderstanding of gschemas.compiled. I don't claim I'm familiar with, but there is documentation.
share/glib-2.0/schemasseems to be the right location to collect gschema XML files.share/glib-2.0/schemas/gschemas.compiledseems to be a file which cannot be installed/packaged in vcpkg. It can be owned only by a single package. But when installing from cache, the set and order of packages may be different. And there is no hook to update such files after installation from cache.- Locations like
share/gtk-4.0/glib-2.0are neither expected by upstream, nor inshare/${PORT}, nor would they help users which need a singlegschema.compiledfor multiple packages.
AFAIU (vcpkg) users need to create gschemas.compiled as part of there deployment.
Taking a look at Debian:
- In the file list, there is no
gschemas.compilednext to the gschema XML files inshare/glib-2.0:
https://packages.debian.org/bookworm/all/libgtk-4-common/filelist
https://packages.debian.org/bookworm/all/libgtk-3-common/filelist - The file exists, but isn't owned by any package:
$ LANG=C dpkg-query -S /usr/share/glib-2.0/schemas/gschemas.compiled dpkg-query: no path found matching pattern /usr/share/glib-2.0/schemas/gschemas.compiled
dg0yt
approved these changes
Aug 22, 2023
autoantwort
pushed a commit
to autoantwort/vcpkg
that referenced
this pull request
Aug 23, 2023
* [gtk, gtk3] Fix install gschemas.compiled of glib-2.0 * update version * Revert changes of gtk3 and disable install gschemas.compiled by gtk * update version * Update gtk3.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33037, fix install
gschemas.compiledofglib-2.0.SHA512s are updated for each updated downloadThe "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file../vcpkg x-add-version --alland committing the result.