Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gtk-3] [gtk] glib-compile-schemas should run after install #33037

Closed
Febbe opened this issue Aug 8, 2023 · 7 comments · Fixed by #33253
Closed

[gtk-3] [gtk] glib-compile-schemas should run after install #33037

Febbe opened this issue Aug 8, 2023 · 7 comments · Fixed by #33253
Assignees
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@Febbe
Copy link
Contributor

Febbe commented Aug 8, 2023

Is your feature request related to a problem? Please describe.

When installing gtk and gtk-3 the file gschemas.compiled is not correctly generated and only those schemes are integrated, which are installed by gtk4 (gtk package).

Proposed solution

glib-compile-schemas should run at the integrate step, after all files are copied (from both gtk-3 and gtk4)

Describe alternatives you've considered

Run it by myself after .\vcpkg.exe integrate install

Additional context

No response

@Febbe Febbe added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Aug 8, 2023
@dg0yt
Copy link
Contributor

dg0yt commented Aug 21, 2023

#33253 (review)

@dg0yt
Copy link
Contributor

dg0yt commented Aug 21, 2023

FTR the bug reports is valid, but I believe that the resolution is to not install any gschemas.compiled.

@Febbe
Copy link
Contributor Author

Febbe commented Aug 21, 2023

You mean, because there is no hook for the integrate step, and it is not solvable in a well-defined manner?

@dg0yt
Copy link
Contributor

dg0yt commented Aug 21, 2023

It is not about the "integrate" step which is unrelated to package installation.
It would need a hook after package installations. But installations from cached artifacts are basically just unpacking some ZIP.

@Febbe
Copy link
Contributor Author

Febbe commented Aug 21, 2023

Right, after any installation, the cache must be updated.
Btw. $<install_dir>\lib\gdk-pixbuf-2.0\2.10.0 \ loaders\* and loaders.cache is also affected.
I recently commented an issue, that gtk-3 does not load SVG's the reason is, that the contents of the loader directory was empty (pixbufloader-svg.dll has been installed to bin, instead of $<install_dir>\lib\gdk-pixbuf-2.0\2.10.0\loaders\) and the corresponding loaders.cache was not recreated at the installation step.

@LilyWangLL
Copy link
Contributor

LilyWangLL commented Aug 22, 2023

FTR the bug reports is valid, but I believe that the resolution is to not install any gschemas.compiled.

I updated my change and disable install gschemas.compiled by gtk.

@dg0yt
Copy link
Contributor

dg0yt commented Aug 22, 2023

BTW if vcpkg would use DESTDIR with meson install, gnome.post_install() would not run any of the cache update scripts.
https://mesonbuild.com/Gnome-module.html#gnomepost_install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants