Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[atk/gdk-pixbuf/gtk/gtk3/harfbuzz/pango] Fix dependency gobject-instrospection of feature instrospection #33792

Merged

Conversation

LilyWangLL
Copy link
Contributor

Fixes #33751, the supports of gobject-instrospection is !static & (native | (windows & x86)), and its dependency has

    {
      "name": "gobject-introspection",
      "host": true
    }

So change the dependency of feature instrospection to gobject-instrospection.

Fix the build error:

Run-time dependency gobject-introspection-1.0 found: NO (tried pkgconfig and cmake)

..\src\2.38.0-91fb0d495c.clean\atk\meson.build:139:2: ERROR: Dependency "gobject-introspection-1.0" not found, tried pkgconfig and cmake
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Sep 15, 2023
@LilyWangLL
Copy link
Contributor Author

cc @mkhon, feature instrospection added by PR #28662.

@LilyWangLL LilyWangLL marked this pull request as ready for review September 18, 2023 07:34
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Sep 18, 2023
@vicroms vicroms merged commit 500700a into microsoft:master Sep 18, 2023
15 checks passed
@mkhon
Copy link
Contributor

mkhon commented Sep 25, 2023

@LilyWangLL It does not look to me that the root cause of arm build breakage was properly analyzed.

  • There must be host gobject-introspection dependency as it has native binaries that are run on the host during the build
  • In addition, x86 gobject-introspection dependency is required when target is windows x86 because x86 python is used in this case and gobject-introspection has both native and python binaries if I remember correctly
  • I don't see how removing dependencies from the gtk/gtk3 would help - are you relying on the gobject-introspection dependency to be pulled up from harfbuzz and atk?

@dg0yt
Copy link
Contributor

dg0yt commented Sep 25, 2023

I remember that I also had different findings for the original problem, but I couldn't finish my work fast enough. (IIRC port libffi was one of the obstacles, and I was able to land a PR to resolve this part of the problem.)

@LilyWangLL LilyWangLL deleted the dev/LilyWang/Feature_introspection branch October 31, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[atk] Build failure
5 participants