Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[atk/gdk-pixbuf/graphene/gtk/gtk3/harfbuzz/pango] Add introspection feature #28662

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

mkhon
Copy link
Contributor

@mkhon mkhon commented Jan 1, 2023

Describe the pull request

  • What does your PR fix?

Implement introspection feature for gtk ports

  • Which triplets are supported/not supported? Have you updated the CI baseline?

all

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

github-actions[bot]
github-actions bot previously approved these changes Jan 1, 2023
@Cheney-W Cheney-W added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jan 3, 2023
@Cheney-W
Copy link
Contributor

Cheney-W commented Jan 3, 2023

WARNING: Recommend using either -Dbuildtype or -Doptimization + -Ddebug. Using both is redundant since they override each other. See: https://mesonbuild.com/Builtin-options.html#build-type-options
The Meson build system
Version: 0.62.1
Source dir: D:\buildtrees\graphene\src\graphene-1-d2ab5b7af5.clean
Build dir: D:\buildtrees\graphene\x86-windows-dbg
Build type: native build

..\src\graphene-1-d2ab5b7af5.clean\meson.build:1:0: ERROR: Value "false" (of type "string") for combo option "Enable GObject Introspection (depends on GObject)" is not one of the choices. Possible choices are (as string): "enabled", "disabled", "auto".

A full log can be found at D:\buildtrees\graphene\x86-windows-dbg\meson-logs\meson-log.txt

All of the CI error logs.

@Cheney-W
Copy link
Contributor

Pinging @mkhon for response. Is work still being done for this PR?

github-actions[bot]
github-actions bot previously approved these changes Jan 15, 2023
@Cheney-W Cheney-W added requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function and removed requires:author-response labels Jan 16, 2023
Cheney-W
Cheney-W previously approved these changes Jan 17, 2023
@Cheney-W Cheney-W changed the title Introspection support [atk/gdk-pixbuf/graphene/gtk/gtk3/harfbuzz/pango] Add introspection feature Jan 17, 2023
@Cheney-W
Copy link
Contributor

Introspection feature passed with following triplets:
x86-windows
x64-windows

@Cheney-W
Copy link
Contributor

@mkhon Could you please solve the conflicts? Thank you!

@Cheney-W Cheney-W added requires:author-response and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Jan 17, 2023
@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 17, 2023
@BillyONeal
Copy link
Member

Looks good, thank you for the new feature :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants