-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[atk/gdk-pixbuf/graphene/gtk/gtk3/harfbuzz/pango] Add introspection feature #28662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkhon
force-pushed
the
feature/gtk-introspection
branch
from
January 1, 2023 18:00
a315d77
to
bbbf5a4
Compare
Cheney-W
added
the
category:port-feature
The issue is with a library, which is requesting new capabilities that didn’t exist
label
Jan 3, 2023
All of the CI error logs. |
Pinging @mkhon for response. Is work still being done for this PR? |
mkhon
force-pushed
the
feature/gtk-introspection
branch
from
January 15, 2023 21:53
bbbf5a4
to
21a3a44
Compare
Cheney-W
added
requires:all-feature-testing
vcpkg install port[all features supported by that port] needs to be demonstrated to function
and removed
requires:author-response
labels
Jan 16, 2023
Cheney-W
previously approved these changes
Jan 17, 2023
Cheney-W
changed the title
Introspection support
[atk/gdk-pixbuf/graphene/gtk/gtk3/harfbuzz/pango] Add introspection feature
Jan 17, 2023
Introspection feature passed with following triplets: |
@mkhon Could you please solve the conflicts? Thank you! |
Cheney-W
added
requires:author-response
and removed
requires:all-feature-testing
vcpkg install port[all features supported by that port] needs to be demonstrated to function
labels
Jan 17, 2023
mkhon
dismissed stale reviews from Cheney-W and github-actions[bot]
via
January 17, 2023 04:40
ea389e3
mkhon
force-pushed
the
feature/gtk-introspection
branch
from
January 17, 2023 04:40
21a3a44
to
ea389e3
Compare
Cheney-W
added
info:reviewed
Pull Request changes follow basic guidelines
and removed
requires:author-response
labels
Jan 17, 2023
Cheney-W
approved these changes
Jan 17, 2023
Looks good, thank you for the new feature :) |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-feature
The issue is with a library, which is requesting new capabilities that didn’t exist
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Implement introspection feature for gtk ports
Which triplets are supported/not supported? Have you updated the CI baseline?
all
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/