Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graphviz,librsvg,libcroco] Refresh #33964

Merged
merged 14 commits into from
Sep 26, 2023
Merged

[graphviz,librsvg,libcroco] Refresh #33964

merged 14 commits into from
Sep 26, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Sep 24, 2023

graphviz

Properly cleanup and refresh patches. Amends #33795. Fixes #33926 which actually is my #33855 (comment) and which delayed feedback on #33795.

libcroco, librsvg

Revise dependencies.
Consistent use of pkgconfig for import and export. I see no benefit from unofficial exported CMake config when it relies on pkgconfig for imported dependencies.

libcroco: Use official (upstream) header installation dir. Install pc file. Drop unofficial debug postfix.
librsvg: Use official pc file name. Always build pixbufloader-svg as module (DLL), and install it to official location (#8015 (comment)).

@JonLiu1993 JonLiu1993 self-assigned this Sep 25, 2023
@dg0yt dg0yt changed the title [graphviz] Refresh [graphviz,librsvg,libcroco] Refresh Sep 25, 2023
@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Sep 25, 2023
@dg0yt dg0yt marked this pull request as ready for review September 25, 2023 07:21
@dg0yt dg0yt marked this pull request as draft September 25, 2023 07:23
@dg0yt dg0yt marked this pull request as ready for review September 25, 2023 07:26
@dg0yt dg0yt marked this pull request as draft September 25, 2023 15:37
@dg0yt dg0yt marked this pull request as ready for review September 25, 2023 19:05
@talregev
Copy link
Contributor

talregev commented Sep 25, 2023

Add an empty comment that will restart the tests and not hangout on license/cla.

@dg0yt dg0yt closed this Sep 25, 2023
@dg0yt dg0yt reopened this Sep 25, 2023
@dg0yt dg0yt closed this Sep 25, 2023
@dg0yt dg0yt reopened this Sep 25, 2023
@JonLiu1993
Copy link
Member

JonLiu1993 commented Sep 26, 2023

Tested usage successfully by librsvg:x64-windows:

librsvg can be imported via CMake FindPkgConfig module:

    find_package(PkgConfig REQUIRED)
    pkg_check_modules(LIBRSVG librsvg-2.0 IMPORTED_TARGET REQUIRED)
    target_link_libraries(main PRIVATE PkgConfig::LIBRSVG)

libcroco:x64-windows:

    find_package(PkgConfig REQUIRED)
    pkg_check_modules(LIBCROCO libcroco-0.6 IMPORTED_TARGET REQUIRED)
    target_link_libraries(main PRIVATE PkgConfig::LIBCROCO)

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Sep 26, 2023
@vicroms vicroms merged commit 7ceccee into microsoft:master Sep 26, 2023
17 checks passed
@dg0yt dg0yt deleted the graphviz branch September 26, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[graphviz] fails on linking glib
4 participants