-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[graphviz,librsvg,libcroco] Refresh #33964
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an empty comment that will restart the tests and not hangout on license/cla. |
JonLiu1993
approved these changes
Sep 26, 2023
JonLiu1993
approved these changes
Sep 26, 2023
Tested usage successfully by
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-bug
The issue is with a library, which is something the port should already support
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
graphviz
Properly cleanup and refresh patches. Amends #33795. Fixes #33926 which actually is my #33855 (comment) and which delayed feedback on #33795.
libcroco, librsvg
Revise dependencies.
Consistent use of pkgconfig for import and export. I see no benefit from unofficial exported CMake config when it relies on pkgconfig for imported dependencies.
libcroco: Use official (upstream) header installation dir. Install pc file. Drop unofficial debug postfix.
librsvg: Use official pc file name. Always build pixbufloader-svg as module (DLL), and install it to official location (#8015 (comment)).