Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[graphviz] update to 9.0.0 #33795

Merged
merged 1 commit into from
Sep 18, 2023
Merged

[graphviz] update to 9.0.0 #33795

merged 1 commit into from
Sep 18, 2023

Conversation

talregev
Copy link
Contributor

@talregev talregev commented Sep 15, 2023 •
edited
Loading

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@talregev
Copy link
Contributor Author

There is a problem with post process (found exe on bin and debug/bin) Not sure how to handle. I will apricate the help.

warning: The following EXEs were found in /bin or /debug/bin. EXEs are not valid distribution targets.

    C:\src\vcpkg\packages\graphviz_x64-windows\bin\cluster.exe
    C:\src\vcpkg\packages\graphviz_x64-windows\bin\dot_builtins.exe
    C:\src\vcpkg\packages\graphviz_x64-windows\bin\gv2gxl.exe
    C:\src\vcpkg\packages\graphviz_x64-windows\bin\gxl2dot.exe
    C:\src\vcpkg\packages\graphviz_x64-windows\bin\prune.exe

warning: The following EXEs were found in /bin or /debug/bin. EXEs are not valid distribution targets.

    C:\src\vcpkg\packages\graphviz_x64-windows\debug\bin\cluster.exe
    C:\src\vcpkg\packages\graphviz_x64-windows\debug\bin\dot_builtins.exe
    C:\src\vcpkg\packages\graphviz_x64-windows\debug\bin\gv2gxl.exe
    C:\src\vcpkg\packages\graphviz_x64-windows\debug\bin\gxl2dot.exe
    C:\src\vcpkg\packages\graphviz_x64-windows\debug\bin\prune.exe

error: Found 2 post-build check problem(s). To submit these ports to curated catalogs, please first correct the portfile: C:\src\vcpkg\ports\graphviz\portfile.cmake

@talregev talregev marked this pull request as draft September 15, 2023 12:14
@talregev talregev changed the title [graphviz] update to 9.0.0 [Help needed][graphviz] update to 9.0.0 Sep 15, 2023
@talregev
Copy link
Contributor Author

talregev commented Sep 15, 2023 •
edited
Loading

On the CI it fail with:

CMake Error at D:/downloads/tools/cmake-3.27.1-windows/cmake-3.27.1-windows-i386/share/cmake-3.27/Modules/FindPkgConfig.cmake:607 (message):
  A required package was not found
Call Stack (most recent call first):
  D:/downloads/tools/cmake-3.27.1-windows/cmake-3.27.1-windows-i386/share/cmake-3.27/Modules/FindPkgConfig.cmake:829 (_pkg_check_modules_internal)
  CMakeLists.txt:128 (pkg_check_modules)

I am not sure why. Any help?
failure logs for x64-windows.zip

@talregev talregev marked this pull request as ready for review September 15, 2023 12:56
@dg0yt
Copy link
Contributor

dg0yt commented Sep 15, 2023

CMakeLists.txt:128 (pkg_check_modules)

Check that line to find the missing dependency.

dg0yt
dg0yt reviewed Sep 15, 2023
View reviewed changes
ports/graphviz/vcpkg.json Outdated Show resolved Hide resolved
@talregev
Copy link
Contributor Author

CMakeLists.txt:128 (pkg_check_modules)

Check that line to find the missing dependency.

127: find_package(PkgConfig)
128: if(PkgConfig_FOUND)

It search for pkgconfig, and it don't find it. Something changed?

@dg0yt
Copy link
Contributor

dg0yt commented Sep 16, 2023

I cited the pkg_check_modules to narrow the search. Mind the patches. Probably this change in your PR:

pkg_check_modules(librsvg REQUIRED IMPORTED_TARGET librsvg)

@talregev
Copy link
Contributor Author

I cited the pkg_check_modules to narrow the search. Mind the patches. Probably this change in your PR:

pkg_check_modules(librsvg REQUIRED IMPORTED_TARGET librsvg)

It actually was the:

128:  pkg_check_modules(GTS gts REQUIRED)

Thank you for your help!

@talregev
Copy link
Contributor Author

Now I have again the problem:

There is a problem with post process (found exe on bin and debug/bin) Not sure how to handle. I will apricate the help.

warning: The following EXEs were found in /bin or /debug/bin. EXEs are not valid distribution targets.

    C:\src\vcpkg\packages\graphviz_x64-windows\bin\cluster.exe
    C:\src\vcpkg\packages\graphviz_x64-windows\bin\dot_builtins.exe
    C:\src\vcpkg\packages\graphviz_x64-windows\bin\gv2gxl.exe
    C:\src\vcpkg\packages\graphviz_x64-windows\bin\gxl2dot.exe
    C:\src\vcpkg\packages\graphviz_x64-windows\bin\prune.exe

warning: The following EXEs were found in /bin or /debug/bin. EXEs are not valid distribution targets.

    C:\src\vcpkg\packages\graphviz_x64-windows\debug\bin\cluster.exe
    C:\src\vcpkg\packages\graphviz_x64-windows\debug\bin\dot_builtins.exe
    C:\src\vcpkg\packages\graphviz_x64-windows\debug\bin\gv2gxl.exe
    C:\src\vcpkg\packages\graphviz_x64-windows\debug\bin\gxl2dot.exe
    C:\src\vcpkg\packages\graphviz_x64-windows\debug\bin\prune.exe

error: Found 2 post-build check problem(s). To submit these ports to curated catalogs, please first correct the portfile: C:\src\vcpkg\ports\graphviz\portfile.cmake

@dg0yt
Copy link
Contributor

dg0yt commented Sep 16, 2023

If there are new tools, you have to update the vcpkg_copy_tools line.

@talregev
Copy link
Contributor Author

If there are new tools, you have to update the vcpkg_copy_tools line.

Thank you, that help!!

@talregev talregev changed the title [Help needed][graphviz] update to 9.0.0 [graphviz] update to 9.0.0 Sep 16, 2023
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Sep 18, 2023
@JonLiu1993 JonLiu1993 linked an issue Sep 18, 2023 that may be closed by this pull request
[graphviz] update to 8.1.0 #33199
Closed
@JonLiu1993
Copy link
Member

All feature are tested successfully in the following triplet:

  • x86-windows
  • x64-windows

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Sep 18, 2023
@vicroms vicroms merged commit 66d350f into microsoft:master Sep 18, 2023
15 checks passed
@talregev talregev deleted the TalR/graphivs branch September 18, 2023 16:58
dg0yt
dg0yt reviewed Sep 18, 2023
View reviewed changes
ports/graphviz/portfile.cmake
Comment on lines +119 to +123
cluster
dot_builtins
gv2gxl
gxl2dot
prune
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It used to be alphabetic.

ports/graphviz/cpp-error.patch
Comment on lines +2 to +3
--- a/cmd/gvedit/mainwindow.cpp
+++ b/cmd/gvedit/mainwindow.cpp
Copy link
Contributor

@dg0yt dg0yt Sep 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But gvedit is explicitly disabled...

@dg0yt dg0yt mentioned this pull request Sep 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[graphviz] update to 8.1.0
4 participants
@talregev @dg0yt @JonLiu1993 @vicroms