-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python3] Add a warning message for installing autoconf automake and autoconf-archive #35548
Conversation
|
I hope this is covered by |
Sorry, I'm not sure what is required of me here. Could you please provide more specific instructions? |
I don't have anything to add (i.e. adding |
if(NOT VCPKG_HOST_IS_WINDOWS) | ||
message(WARNING "${PORT} currently requires the following programs from the system package manager: | ||
autoconf automake autoconf-archive | ||
On Debian and Ubuntu derivatives: | ||
sudo apt-get install autoconf automake autoconf-archive | ||
On recent Red Hat and Fedora derivatives: | ||
sudo dnf install autoconf automake autoconf-archive | ||
On Arch Linux and derivatives: | ||
sudo pacman -S autoconf automake autoconf-archive | ||
On Alpine: | ||
apk add autoconf automake autoconf-archive | ||
On macOS: | ||
brew install autoconf automake autoconf-archive\n") | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Further increasing the level of inconsistency in presenting this common stuff from individual ports. 😞
@Neumann-A In a future vcpkg-make
port, this belongs to the AUTOCONFIG
option IMO. Ideally connected with checks that suppress the annoying message if the tools are available.
(I would have done that in vcpkg_configure_make
, but I was told that no bugs should be fixed there.)
…autoconf-archive (microsoft#35548) * [python3] Add a warning message for installing autoconf automake and autoconf-archive * Apply suggestion
Add a warning to prevent issues similar to #33080
SHA512s are updated for each updated downloadThe "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.