Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python3] Add a warning message for installing autoconf automake and autoconf-archive #35548

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

Cheney-W
Copy link
Contributor

@Cheney-W Cheney-W commented Dec 7, 2023

Add a warning to prevent issues similar to #33080

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Dec 7, 2023
ports/python3/portfile.cmake Outdated Show resolved Hide resolved
ports/python3/portfile.cmake Outdated Show resolved Hide resolved
@Osyotr
Copy link
Contributor

Osyotr commented Dec 8, 2023

pkg-config is also required but I'm not sure it worth mentioning

@dg0yt
Copy link
Contributor

dg0yt commented Dec 8, 2023

pkg-config is also required but I'm not sure it worth mentioning

I hope this is covered by vfap(PKGCONFIG).

@Cheney-W
Copy link
Contributor Author

Cheney-W commented Dec 8, 2023

I hope this is covered by vfap(PKGCONFIG).

Sorry, I'm not sure what is required of me here. Could you please provide more specific instructions?

@Osyotr
Copy link
Contributor

Osyotr commented Dec 8, 2023

Sorry, I'm not sure what is required of me here. Could you please provide more specific instructions?

I don't have anything to add (i.e. adding pkg-config is not required because it should be handled in vcpkg_find_acquire_package(PKGCONFIG)).

@Cheney-W Cheney-W marked this pull request as ready for review December 11, 2023 02:38
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Dec 11, 2023
Comment on lines +6 to +19
if(NOT VCPKG_HOST_IS_WINDOWS)
message(WARNING "${PORT} currently requires the following programs from the system package manager:
autoconf automake autoconf-archive
On Debian and Ubuntu derivatives:
sudo apt-get install autoconf automake autoconf-archive
On recent Red Hat and Fedora derivatives:
sudo dnf install autoconf automake autoconf-archive
On Arch Linux and derivatives:
sudo pacman -S autoconf automake autoconf-archive
On Alpine:
apk add autoconf automake autoconf-archive
On macOS:
brew install autoconf automake autoconf-archive\n")
endif()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further increasing the level of inconsistency in presenting this common stuff from individual ports. 😞

@Neumann-A In a future vcpkg-make port, this belongs to the AUTOCONFIG option IMO. Ideally connected with checks that suppress the annoying message if the tools are available.
(I would have done that in vcpkg_configure_make, but I was told that no bugs should be fixed there.)

@vicroms vicroms merged commit 0da40a8 into microsoft:master Dec 12, 2023
15 checks passed
@Cheney-W Cheney-W deleted the Dev/Cheney/33080 branch December 13, 2023 02:17
autoantwort pushed a commit to autoantwort/vcpkg that referenced this pull request Dec 13, 2023
…autoconf-archive (microsoft#35548)

* [python3] Add a warning message for installing autoconf automake and autoconf-archive

* Apply suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants