Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python3] Add a warning message for installing autoconf automake and autoconf-archive #35548

Merged
merged 2 commits into from
Dec 12, 2023
Merged

[python3] Add a warning message for installing autoconf automake and autoconf-archive #35548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e56ac4
[python3] Add a warning message for installing autoconf automake and …
Cheney-W Dec 7, 2023
de07be3
Apply suggestion
Cheney-W Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ports/python3/portfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,21 @@ if (VCPKG_LIBRARY_LINKAGE STREQUAL dynamic AND VCPKG_CRT_LINKAGE STREQUAL static
set(VCPKG_LIBRARY_LINKAGE static)
endif()

if(NOT VCPKG_HOST_IS_WINDOWS)
message(WARNING "${PORT} currently requires the following programs from the system package manager:
autoconf automake autoconf-archive
On Debian and Ubuntu derivatives:
sudo apt-get install autoconf automake autoconf-archive
On recent Red Hat and Fedora derivatives:
sudo dnf install autoconf automake autoconf-archive
On Arch Linux and derivatives:
sudo pacman -S autoconf automake autoconf-archive
On Alpine:
apk add autoconf automake autoconf-archive
On macOS:
brew install autoconf automake autoconf-archive\n")
endif()
Comment on lines +6 to +19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further increasing the level of inconsistency in presenting this common stuff from individual ports. 😞

@Neumann-A In a future vcpkg-make port, this belongs to the AUTOCONFIG option IMO. Ideally connected with checks that suppress the annoying message if the tools are available.
(I would have done that in vcpkg_configure_make, but I was told that no bugs should be fixed there.)


string(REGEX MATCH "^([0-9]+)\\.([0-9]+)\\.([0-9]+)" PYTHON_VERSION "${VERSION}")
set(PYTHON_VERSION_MAJOR "${CMAKE_MATCH_1}")
set(PYTHON_VERSION_MINOR "${CMAKE_MATCH_2}")
Expand Down
2 changes: 1 addition & 1 deletion ports/python3/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "python3",
"version": "3.11.5",
"port-version": 2,
"port-version": 3,
"description": "The Python programming language",
"homepage": "https://github.com/python/cpython",
"license": "Python-2.0",
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6862,7 +6862,7 @@
},
"python3": {
"baseline": "3.11.5",
"port-version": 2
"port-version": 3
},
"qca": {
"baseline": "2.3.7",
Expand Down
5 changes: 5 additions & 0 deletions versions/p-/python3.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "e6acf202b9752a04a0b9557d1ea9e4fa2f427e8d",
"version": "3.11.5",
"port-version": 3
},
{
"git-tree": "f51d67945e156a17ca72a743f04455a368e73272",
"version": "3.11.5",
Expand Down