Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcpkg.targets not imported automatically into MSBuild based port projects during build #891

Closed
4creators opened this issue Apr 3, 2017 · 2 comments
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed

Comments

@4creators
Copy link
Contributor

4creators commented Apr 3, 2017

Playing with guetzli JPEG encoder port (it's exe, so there is another problem to discuss) I have encountered a problem with using already installed vcpkg packages. vcpkg MSBuild implementation did not pick it up unless explicitly asked for doing so with OPTIONS /p:ForceImportBeforeCppTargets=${VCPKG_ROOT_DIR}/scripts/buildsystems/msbuild/vcpkg.targets inside vcpkg_build_msbuild. In my opinion every new package should use installed vcpkg packages by default without the need to explicitly set it during packaging in port file.

@ras0219-msft
Copy link
Contributor

Related: #828

@ras0219-msft ras0219-msft added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Apr 5, 2017
@researcher2
Copy link

Hello. I'm trying to create a portfile for my library and this is still happening. Not sure if it makes a difference but I'm trying to build using static CRT linkage. Adding "OPTIONS /p:ForceImportBeforeCppTargets=${VCPKG_ROOT_DIR}/scripts/buildsystems/msbuild/vcpkg.targets" to "vcpkg_build_msbuild" fixes the problem as mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
Projects
None yet
Development

No branches or pull requests

3 participants