Fix race condition in async enum tracker #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `BufferBlock<T>.Complete()` can set its own `Completion` property to complete asynchronously. If `ReceiveAsync()` can throw due to completion *before* its `Completion.IsCompleted` is set to `true`, that would repro this problem. I haven't been able to confirm by code inspection or debugger that the `BufferBlock` could do this, but based on the exception you report, I can come to no other conclusion. Based on the documentation of the API, it appears that it's safe to assume than any `InvalidOperationException` is thrown only in the case of a completed block though, so to fix this, I will remove the `when` clause. Fixes microsoft#867
AArnott
requested review from
CyrusNajmabadi,
ankitvarmait and
matteo-prosperi
matteo-prosperi
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
BufferBlock<T>.Complete()can set its ownCompletionproperty to complete asynchronously. IfReceiveAsync()can throw due to completion before itsCompletion.IsCompletedis set totrue, that would repro this problem. I haven't been able to confirm by code inspection or debugger that theBufferBlockcould do this, but based on the exception you report, I can come to no other conclusion. Based on the documentation of the API, it appears that it's safe to assume than anyInvalidOperationExceptionis thrown only in the case of a completed block though, so to fix this, I will remove thewhenclause.Fixes #867