Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate breakpoint resolution in sourcemapped scripts #52

Closed
connor4312 opened this issue Oct 25, 2019 · 2 comments
Closed

Validate breakpoint resolution in sourcemapped scripts #52

connor4312 opened this issue Oct 25, 2019 · 2 comments
Labels
debt Code quality issues

Comments

@connor4312
Copy link
Member

connor4312 commented Oct 25, 2019

Previous versions of the debug adapter had breakOnLoad options that we used to ensure scripts and breakpoints were set before evaluating the script. PWA works a little more intelligently by using the beforeScriptWithSourceMapExecution instrumentation breakpoint and resolving and user-defined breakpoints at that time. This seems to work well in my testing, but we should monitor and ensure that there aren't edge cases it ends up missing.

bc19ac0

@connor4312 connor4312 mentioned this issue Oct 25, 2019
93 tasks
@connor4312
Copy link
Member Author

We ran into issues here when debugging VS Code extensions. The existing sourcemap resolution logic behaves quite well if the debugee contains mostly or only our own code, but is tripped up when there's third-party sources that conflict with the ones we're interested in.

@connor4312 connor4312 added this to the v0.1.0 milestone Nov 4, 2019
@connor4312 connor4312 added the debt Code quality issues label Nov 4, 2019
@connor4312
Copy link
Member Author

Moving this out to other more specific issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

1 participant