Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have an event for changing kernels, or don't allow if a debugging session is active #7180

Closed
Tracked by #5607
DavidKutu opened this issue Aug 18, 2021 · 0 comments
Closed
Tracked by #5607

Have an event for changing kernels, or don't allow if a debugging session is active #7180

DavidKutu opened this issue Aug 18, 2021 · 0 comments
Assignees
@DavidKutu
Labels
bug Issue identified by VS Code Team member as probable bug notebook-run-by-line verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2021

Comments

@DavidKutu
Copy link

If a user changes the kernel while a debug session is active, they get stuck in a glitched state. The debug session needs to be disconnected before that.

IKernel has an onDisposed, but that is too late.

We need to either have an event that the DebuggingManager can catch to disconnect, or prevent the user of being able to change the kernel while debugging.
@DavidKutu DavidKutu added the bug Issue identified by VS Code Team member as probable bug label Aug 18, 2021
@DavidKutu DavidKutu mentioned this issue Aug 18, 2021
Closed
@DavidKutu DavidKutu self-assigned this Aug 18, 2021
This was referenced Aug 18, 2021
Closed
Merged
@DavidKutu DavidKutu added this to the August 2021 milestone Aug 19, 2021
@DonJayamanne DonJayamanne added verification-needed Verification of issue is requested verified Verification succeeded labels Aug 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DavidKutu DavidKutu

Labels
bug Issue identified by VS Code Team member as probable bug notebook-run-by-line verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2021
Development

No branches or pull requests
2 participants
@DonJayamanne @DavidKutu