Create Maven Project input textboxes don't work.

[sjacobs-mn]

Create Maven Project input textboxes don't work.

Environment:

• VS Code Version: Version:
  1.73.0 (user setup)
  Commit: 8fa188b2b301d36553cbc9ce1b0a146ccb93351f
  Date: 2022-11-01T15:34:06.111Z
  Electron: 19.0.17
  Chromium: 102.0.5005.167
  Node.js: 16.14.2
  V8: 10.2.154.15-electron.0
  OS: Windows_NT x64 10.0.19044
  Sandboxed: No

• Extension Version:
  Extension Pack for Java v0.25.4
  Maven for Java v0.39.1

• JDK Type & Version:
  open JDK 17.0.4
  Maven 3.6.3

• OS Type & Version:
  Windows 10 with remote development into VMWare Ubuntu 22.04 VM.
  Above extensions are installed to remote VM.

Step to Reproduce:

• Any of the methods for creating a new maven project such as + button on Maven group of Explorer.
• Select "maven-archetype-quickstart"
• Select version "1.4"
• Input for Group ID is prepopulated with "com.example"
• Move cursor to end of text to delete "example" and backspace to the '.'
• Box turns red stating Invalid Group Id and can no longer be interacted with.
  
• If you are careful not to delete everything after the period at once so it is never invalid you can proceed but the next prompt for artifact Id behaves the same way.

Expected Behavior:
Inputs are validated after they are completed and accepted if valid.

Actual Behavior:
Inputs are validated as typed and dialog is disabled if the input ever becomes invalid.

Related Issues:
no

[Eskibear]

I can reproduce it on VS Code 1.73.0. And it works well on 1.72.2. Probably a regression of VS Code.

[Eskibear]

         /**
         * If the UI should allow for user input. Defaults to true.
         *
         * Change this to false, e.g., while validating user input or
         * loading data for the next step in user input.
         */
        enabled: boolean;

vscode-maven/src/archetype/createProject/SpecifyGroupIdStep.ts

Lines 30 to 33 in 76cd0b0

	inputBox.onDidChangeValue(() => {
	const validationMessage: string | undefined = this.groupIdValidation(inputBox.value);
	inputBox.enabled = validationMessage === undefined;
	inputBox.validationMessage = validationMessage;

Looks like it's abuse of the enabled API. /cc @CsCherrYY

[jdneo]

BTW should we file an issue to VS Code repo?

[CsCherrYY]

BTW should we file an issue to VS Code repo?

The newest update just makes VS Code behaves as document mentioned.. The previous version has wrong behavior I think.

[sjacobs-mn]

Thanks for fixing so quickly!