Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pattern matching regex to handle errors when they don't have a column number #156

Closed
sdelquin opened this issue Sep 20, 2023 · 3 comments · Fixed by #237
Closed
Labels
bug Issue identified by VS Code Team member as probable bug good first issue Good for newcomers needs PR

Comments

@sdelquin
Copy link

image

@karthiknadig
Copy link
Member

We require a column number currently to show errors at the right location. I think we can improve the patter matching to capture these cases as column 0.

The regex for this is here:

r"^(?P<location>(?P<filepath>..[^:]*):(?P<line>\d+):(?P<char>\d+)(?::(?P<end_line>\d+):(?P<end_char>\d+))?): (?P<type>\w+): (?P<message>.*?)(?: \[(?P<code>[\w-]+)\])?$"

@karthiknadig karthiknadig added good first issue Good for newcomers ghc-osd needs PR bug Issue identified by VS Code Team member as probable bug and removed triage-needed labels Sep 21, 2023
@luabud luabud changed the title Not showing generator error Change pattern matching regex to handle errors when they don't have a column number Sep 21, 2023
@Tishly
Copy link

Tishly commented Sep 22, 2023

Hi, please can I get assigned to this issue?

@luabud
Copy link
Member

luabud commented Nov 4, 2023

Hi @Tishly, since it's been one month since OSD I'm removing you as an assignee. You can still feel free to submit a PR to this issue if you'd like, but we're going to leave it open for other contributors too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug good first issue Good for newcomers needs PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants