Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions not shown in PR checks #1105

Closed
KnisterPeter opened this issue Apr 5, 2019 · 6 comments · Fixed by #2053
Closed

Github Actions not shown in PR checks #1105

KnisterPeter opened this issue Apr 5, 2019 · 6 comments · Fixed by #2053
Assignees
Labels
feature-request Request for new features or functionality
Milestone

Comments

@KnisterPeter
Copy link

  • Extension version: 0.6.0
  • VSCode Version: 1.33.0
  • OS: Arch Linux

Steps to Reproduce:

  1. Open a project with github actions and open PR which are marked as require in protected branch configuration
  2. In the shown check on the github website for this PR the actions are listed as checks, in vscode the github action checks are missing
@RMacfarlane RMacfarlane added the feature-request Request for new features or functionality label Oct 9, 2019
@DanTup
Copy link

DanTup commented May 7, 2020

This seems quite dangerous - if you had a larger number of checks, you might not realise that there are failed checks not showing up 😕

Screenshot 2020-05-07 at 12 03 28
Screenshot 2020-05-07 at 12 03 33

@JustinGrote
Copy link

The only checks I see come up are Appveyor even though I have many other checks (15 in total). @RMacfarlane any idea why they are being filtered? This seems more like a bug than a feature request.

image
image

@RMacfarlane
Copy link
Contributor

The view in GitHub combines data from a couple of different sources. In the extension right now, we're using this "combined status for a specific ref" API: https://developer.github.com/v3/repos/statuses/#get-the-combined-status-for-a-specific-ref

Originally I thought this would return all of the checks, but GitHub action results are not included in this result. So, we need to make an additional query to get those, or change it to use a graphql query to get all of the data to display

@JustinGrote
Copy link

JustinGrote commented May 7, 2020

@RMacfarlane apparently the API required is in preview but it is here:
https://developer.github.com/v3/checks/runs/#list-check-runs-for-a-git-reference

This article contains a unified GraphQL query as long as there are less than 100 checks.
https://dev.to/gr2m/github-api-how-to-retrieve-the-combined-pull-request-status-from-commit-statuses-check-runs-and-github-action-results-2cen

@JustinGrote
Copy link

JustinGrote commented May 8, 2020

FYI it does still enforce the checks even if not visible in this pane, so I feel a bit better about that at least:
image

@JustinGrote
Copy link

As an update, I recently had to rebuild my Azure Pipelines connection, and now it started showing up in Checks API for some reason...
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants