Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing checks not showing up at all #790

Closed
Tyriar opened this issue Jan 7, 2019 · 2 comments · Fixed by #2053
Closed

Failing checks not showing up at all #790

Tyriar opened this issue Jan 7, 2019 · 2 comments · Fixed by #2053
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 7, 2019

ext version: 1.7.1

I reloaded the window just to make sure it wasn't a sync issue.

Repro:

  1. Checkout Emoji fix xtermjs/xterm.js#1890
  2. View description

PR:

image

.com:

image

output:

[Info] C:\Users\daimms.REDMOND\.ssh\config: ENOENT: no such file or directory, open 'C:\Users\daimms.REDMOND\.ssh\config'
[Info] Looking for git repository
[Info] Git repository found, initializing review manager and pr tree view.
[Info] No GitHub remotes found
[Info] No GitHub remotes found
[Info] Found GitHub remote
[Info] Review> current branch pr/juancampa/1890 is associated with pull request #1890
[Info] Review> register comments provider
[Info] Review> display pull request status bar indicator and refresh pull request tree view.
@RMacfarlane RMacfarlane self-assigned this Jan 8, 2019
@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Jan 8, 2019
@RMacfarlane
Copy link
Contributor

@Tyriar Are the checks in xtermjs GitHub actions? Wondering if this is the same as #1105

@Tyriar
Copy link
Member Author

Tyriar commented Aug 13, 2020

@RMacfarlane xterm.js only uses ADO pipelines now, I see this now:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@Tyriar @RMacfarlane and others