Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native locator for global python installs and virtual environments #23232

Closed
23 of 25 tasks
karthiknadig opened this issue Apr 14, 2024 · 0 comments
Closed
23 of 25 tasks
Assignees
Labels
area-environments Features relating to handling interpreter environments needs PR Ready to be worked on verified Verification succeeded
Milestone

Comments

@karthiknadig
Copy link
Member

karthiknadig commented Apr 14, 2024

Misc

Problems identified

  • Environments resolved in old code will end up overriding info resolved by Native Locator
    More
    Native locator returns 100% of information 99% of the time.
    In the case of Windows store we do not have the version information
    While native locator is finding environments, its possible for old code path to resolve an enviornment (e.g. a global env selected as active env), then the old code could resolve this and by the time the old code gets the env info, the latest env info has been set in cache, However this gets overridden by the env info retrieved by old code path.
    While this might sound ok, some of the information retrieved by old locators is incorrect, e.g. a conda enviornment will be detected as unknown, or global system env will be detected as unknown, other conda as something else...
    I think the best way to address this is to have the native locator also resolve environments on demand (i.e. have native locator provide the ability to spawn and return the information).
    Else all of the run commands, etc computed by native locator will end up getting overridden by the old locator resolver code.
@karthiknadig karthiknadig added feature-request Request for new features or functionality area-environments Features relating to handling interpreter environments needs PR Ready to be worked on labels Apr 14, 2024
@karthiknadig karthiknadig self-assigned this Apr 14, 2024
@karthiknadig karthiknadig added this to the April 2024 milestone Apr 14, 2024
@karthiknadig karthiknadig modified the milestones: April 2024, May 2024 Apr 17, 2024
@luabud luabud modified the milestones: May 2024, June 2024 May 27, 2024
@karthiknadig karthiknadig modified the milestones: June 2024, July 2024 Jun 20, 2024
@karthiknadig karthiknadig added the verified Verification succeeded label Jul 22, 2024
@DonJayamanne DonJayamanne removed the feature-request Request for new features or functionality label Jul 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments needs PR Ready to be worked on verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants