Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoveUp Line Auto-Indent #484

Closed
Astrantia opened this issue Dec 24, 2017 · 5 comments
Closed

MoveUp Line Auto-Indent #484

Astrantia opened this issue Dec 24, 2017 · 5 comments
Labels
area-formatting feature-request Request for new features or functionality

Comments

@Astrantia
Copy link

Astrantia commented Dec 24, 2017

Environment data

VS Code version: 1.19.1
Python Extension version: 0.9.1
Python Version: 3.6
OS and version: Windows 10

Actual behavior

When moving up lines with key shortcut Alt+UpArrow or moving down with Alt+DownArrow, extension doesn't auto-indent blocks of code.
gif <--- Illustrates the issue.

Expected behavior

Auto-indentation should be added when moving up lines of code. I understand that some people would rather not have this feature added, but I think there should at least be a config option to enable/disable auto-indenting.

Steps to reproduce:

https://i.imgur.com/ZahMTvY.gifv

@Astrantia
Copy link
Author

Astrantia commented Mar 17, 2018

Can this issue be given a priority? @DonJayamanne @MikhailArkhipov

@DonJayamanne
Copy link

Unfortunately there doesn't seem to be any interest in this feature from other users. we won't be looking into this at this stage, as there are other bugs and features that are more popular and higher priority (with more users interested in them).

@brettcannon
Copy link
Member

@DonJayamanne is this feasible? In which case we can make this a "Help Wanted" feature.

@brettcannon brettcannon added info-needed Issue requires more information from poster and removed needs decision labels Apr 10, 2018
@DonJayamanne
Copy link

@brettcannon

  1. This would have to be done as part of the analysis engine, however.
  2. Moving lines up/down is done by VSC, and we do not have any hooks on formatting the code as they move around. Hence we'll need to create our own commands to move lines up/down (creating our own edits..). This would lead to us duplicating what VSC does today with minor changes.

I'd kind of like format on paste, here we need format on line edit.
I.e. we need some VSC hooks to get this done correctly.

@brettcannon brettcannon removed the info-needed Issue requires more information from poster label Apr 11, 2018
@brettcannon
Copy link
Member

OK, based on the fact that we need VS Code hooks to implement this I'm going to close it. @sulkhanp if you are up for opening an issue at Microsoft/vscode for the appropriate APIs then we can re-open this once those APIs exist.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-formatting feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants